lint_project and project_report return unbounded, pretty-printed findings

Abierto
#129 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
58/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
api, performance

Línea de trabajo

Start by reading src/tools/lint.ts and src/tools/scenes.ts at the cited locations, then inspect src/tools/result.ts and the generated tool definitions. Compare the response shape with the acceptance criteria: lint_project should cap findings by default and include the total and truncation flag, while summary mode should return counts only. Run npm run generate:tools after changes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

help wanted performance severity: medium

Summary

lint_project and project_report return every finding in one pretty-printed text block, with no limit, paging or summary mode. On a realistic untyped project this is tens of megabytes, far beyond what an MCP client or LLM context can take.

Where

  • src/tools/lint.ts:65, src/tools/scenes.ts:100
  • src/tools/result.ts:9 (JSON.stringify(data, null, 2))

Details

A synthetic project with 3000 scripts produced 108k lint findings: 90k untyped-declaration, which is on by default, plus 6k stringly-nodepath. JSON output was 37.3 MB for lint and 39.5 MB for report. Even 10k findings is about 3.5 MB. The server-side cost (sort 264 ms, stringify 154 ms) is small; the problem is the size of the response.

Impact

On real projects that do not use static typing, the main MCP tools return responses that clients truncate or reject, so agents cannot use them.

Suggested fix

  • Add maxFindings (default for example 500, with truncated: true and the total count in the payload) and offset.
  • Add a summary mode that returns counts per rule and per file.
  • Drop the indentation in ok().
  • Run npm run generate:tools afterwards.

Acceptance criteria

  • By default, lint_project on a project with more findings than the limit returns at most the limit, plus totalFindings and a truncation flag.
  • Summary mode returns counts only.

Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: performance|src/tools/result.ts|ok

Lenguaje dominante
TypeScript
Estrellas
0
Forks
6
Merge medio
1 d 21 h
PR fusionados (30 d)
8

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/godot-correctness-mcp

Todos los issues de TMHSDigital/godot-correctness-mcp

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.