Live-Pi e2e suite never runs and would time out at Vitest's 5s default
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 68/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- docker, github-actions, typescript
调研方向
Start with .github/workflows/e2e.yml:13 to see the PI_CONFIGURED gate, then read mcp-server/src/tools/__tests__/e2e.test.ts around lines 14, 45 and 58-60 for the missing timeout and the diskUsage path. Run cd mcp-server && npm install && npm test and npm run typecheck to confirm the current e2e behavior. Done means the real-Pi suite has explicit timeouts and a PR-triggered e2e job exercises ssh2 against an openssh-server service container without Pi hardware.
由索引模型根据 Issue 内容生成。
描述
Summary
The e2e workflow is gated on a repository variable that is not set, so every scheduled run is skipped and no real SSH path is exercised in CI. If enabled, tests would hit Vitest's 5 s default timeout.
Where
.github/workflows/e2e.yml:13mcp-server/src/tools/__tests__/e2e.test.ts:14, :45, :58-60
Details
The last five scheduled runs (2026-10-18 to 2026-11-15) were all skipped. There is no vitest config or per-test timeout, while execSSH allows a 10 s connect plus a 30 s exec, and the e2e diskUsage case walks / with du, which on an SD card very likely takes longer than 5 s.
Impact
The only tests against real remote output give no signal, so parser regressions in piStatus, kernelInfo, networkInfo and similar tools are not caught. Turning the suite on would first produce timeout failures unrelated to tool behavior.
Suggested fix
- Add
{ timeout: 60_000 }to the e2edescribeand use a small path (for example/var/log) for diskUsage. - Add a CI e2e job that needs no Pi: an
openssh-serverservice container on ubuntu-latest,HOMELAB_PI_*pointed at it, and the read-only tools that need no Pi hardware (sshTest, kernelInfo, networkInfo, diskUsage on /tmp, healthCheck). This exercises ssh2, key loading and exit-code/stderr mapping. - On
workflow_dispatch, fail or post a notice whenPI_CONFIGUREDis unset instead of reporting skipped.
Acceptance criteria
- An e2e job runs on every PR against a containerized SSH server
- Real-Pi suite has explicit timeouts
Getting started
- Relevant files:
.github/workflows/e2e.yml,mcp-server/src/tools/__tests__/e2e.test.ts - How to run tests:
cd mcp-server && npm install && npm test(andnpm run typecheck); structure tests:pip install -r requirements-test.txt && pytest tests/ -v - Conventions: see
CLAUDE.mdandCONTRIBUTING.md
Filed by repo-audit/full-audit at 636fefb. Severity: medium. Effort: M. audit-key: testing|mcp-server/src/tools/__tests__/e2e.test.ts|e2e
- 主要语言
- TypeScript
- 星标
- 0
- 派生
- 4
- 平均合并
- 10 小时 16 分钟
- 30 天内合并 PR
- 2
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
TMHSDigital/Home-Lab-Developer-Tools 的其他 Issue
-
speedtestResults ignores count: /api/speedtest/latest returns one result可能已有人在做 @laozhej 于 2 天前认领。 未关闭bug severity: low
难度 2/5 1-3 小时 新手友好度 80/100
TMHSDigital/Home-Lab-Developer-Tools#160 ·
维护者通常 1 天内回复
-
Integration tests import tool modules inside tests and can time out under load可能已有人在做 @laozhej 于 2 天前认领。 未关闭good first issue severity: low testing
难度 2/5 1-3 小时 新手友好度 25/100
TMHSDigital/Home-Lab-Developer-Tools#174 ·
维护者通常 1 天内回复
-
Grafana dashboard import to complete the export/import round trip可能已有人在做 @laozhej 今天认领。 未关闭enhancement severity: low
难度 3/5 1-2 天 新手友好度 68/100
TMHSDigital/Home-Lab-Developer-Tools#171 ·
维护者通常 1 天内回复
-
help wanted severity: low testing
难度 4/5 3-5 天 新手友好度 55/100
TMHSDigital/Home-Lab-Developer-Tools#164 · 1 条评论 ·
维护者通常 1 天内回复
-
enhancement severity: medium
难度 3/5 1-2 天 新手友好度 72/100
TMHSDigital/Home-Lab-Developer-Tools#159 ·
维护者通常 1 天内回复
查看 TMHSDigital/Home-Lab-Developer-Tools 的全部 Issue
相似的 Issue
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)未关闭
难度 2/5 1-3 小时 新手友好度 62/100
microsoft/playwright#44289 ·
维护者通常 1 天内回复
-
good first issue
难度 2/5 半天 新手友好度 65/100
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 72/100
blamechris/chroxy#9272 ·
维护者通常 1 天内回复
-
no-repo-link tool-submission
难度 1/5 1 小时以内 新手友好度 66/100
BraveOPotato/NoSignups#2458 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
drmrd/vernacular#1061 ·
维护者通常 1 天内回复