Live-Pi e2e suite never runs and would time out at Vitest's 5s default

Ouverte
#151 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
68/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
docker, github-actions, typescript
Domaine
ci-cd, testing

Piste de recherche

Start with .github/workflows/e2e.yml:13 to see the PI_CONFIGURED gate, then read mcp-server/src/tools/__tests__/e2e.test.ts around lines 14, 45 and 58-60 for the missing timeout and the diskUsage path. Run cd mcp-server && npm install && npm test and npm run typecheck to confirm the current e2e behavior. Done means the real-Pi suite has explicit timeouts and a PR-triggered e2e job exercises ssh2 against an openssh-server service container without Pi hardware.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

help wanted severity: medium testing

Summary

The e2e workflow is gated on a repository variable that is not set, so every scheduled run is skipped and no real SSH path is exercised in CI. If enabled, tests would hit Vitest's 5 s default timeout.

Where

  • .github/workflows/e2e.yml:13
  • mcp-server/src/tools/__tests__/e2e.test.ts:14, :45, :58-60

Details

The last five scheduled runs (2026-10-18 to 2026-11-15) were all skipped. There is no vitest config or per-test timeout, while execSSH allows a 10 s connect plus a 30 s exec, and the e2e diskUsage case walks / with du, which on an SD card very likely takes longer than 5 s.

Impact

The only tests against real remote output give no signal, so parser regressions in piStatus, kernelInfo, networkInfo and similar tools are not caught. Turning the suite on would first produce timeout failures unrelated to tool behavior.

Suggested fix

  • Add { timeout: 60_000 } to the e2e describe and use a small path (for example /var/log) for diskUsage.
  • Add a CI e2e job that needs no Pi: an openssh-server service container on ubuntu-latest, HOMELAB_PI_* pointed at it, and the read-only tools that need no Pi hardware (sshTest, kernelInfo, networkInfo, diskUsage on /tmp, healthCheck). This exercises ssh2, key loading and exit-code/stderr mapping.
  • On workflow_dispatch, fail or post a notice when PI_CONFIGURED is unset instead of reporting skipped.

Acceptance criteria

  • An e2e job runs on every PR against a containerized SSH server
  • Real-Pi suite has explicit timeouts

Getting started

  • Relevant files: .github/workflows/e2e.yml, mcp-server/src/tools/__tests__/e2e.test.ts
  • How to run tests: cd mcp-server && npm install && npm test (and npm run typecheck); structure tests: pip install -r requirements-test.txt && pytest tests/ -v
  • Conventions: see CLAUDE.md and CONTRIBUTING.md

Filed by repo-audit/full-audit at 636fefb. Severity: medium. Effort: M. audit-key: testing|mcp-server/src/tools/__tests__/e2e.test.ts|e2e

Langage dominant
TypeScript
Étoiles
0
Forks
4
Merge moyen
10 h 16 min
PR mergées (30 j)
2

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TMHSDigital/Home-Lab-Developer-Tools

Toutes les issues de TMHSDigital/Home-Lab-Developer-Tools

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.