Live-Pi e2e suite never runs and would time out at Vitest's 5s default

Aberta
#151 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
68/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
docker, github-actions, typescript
Domínio
ci-cd, testing

Direção de pesquisa

Start with .github/workflows/e2e.yml:13 to see the PI_CONFIGURED gate, then read mcp-server/src/tools/__tests__/e2e.test.ts around lines 14, 45 and 58-60 for the missing timeout and the diskUsage path. Run cd mcp-server && npm install && npm test and npm run typecheck to confirm the current e2e behavior. Done means the real-Pi suite has explicit timeouts and a PR-triggered e2e job exercises ssh2 against an openssh-server service container without Pi hardware.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

help wanted severity: medium testing

Summary

The e2e workflow is gated on a repository variable that is not set, so every scheduled run is skipped and no real SSH path is exercised in CI. If enabled, tests would hit Vitest's 5 s default timeout.

Where

  • .github/workflows/e2e.yml:13
  • mcp-server/src/tools/__tests__/e2e.test.ts:14, :45, :58-60

Details

The last five scheduled runs (2026-10-18 to 2026-11-15) were all skipped. There is no vitest config or per-test timeout, while execSSH allows a 10 s connect plus a 30 s exec, and the e2e diskUsage case walks / with du, which on an SD card very likely takes longer than 5 s.

Impact

The only tests against real remote output give no signal, so parser regressions in piStatus, kernelInfo, networkInfo and similar tools are not caught. Turning the suite on would first produce timeout failures unrelated to tool behavior.

Suggested fix

  • Add { timeout: 60_000 } to the e2e describe and use a small path (for example /var/log) for diskUsage.
  • Add a CI e2e job that needs no Pi: an openssh-server service container on ubuntu-latest, HOMELAB_PI_* pointed at it, and the read-only tools that need no Pi hardware (sshTest, kernelInfo, networkInfo, diskUsage on /tmp, healthCheck). This exercises ssh2, key loading and exit-code/stderr mapping.
  • On workflow_dispatch, fail or post a notice when PI_CONFIGURED is unset instead of reporting skipped.

Acceptance criteria

  • An e2e job runs on every PR against a containerized SSH server
  • Real-Pi suite has explicit timeouts

Getting started

  • Relevant files: .github/workflows/e2e.yml, mcp-server/src/tools/__tests__/e2e.test.ts
  • How to run tests: cd mcp-server && npm install && npm test (and npm run typecheck); structure tests: pip install -r requirements-test.txt && pytest tests/ -v
  • Conventions: see CLAUDE.md and CONTRIBUTING.md

Filed by repo-audit/full-audit at 636fefb. Severity: medium. Effort: M. audit-key: testing|mcp-server/src/tools/__tests__/e2e.test.ts|e2e

Linguagem predominante
TypeScript
Estrelas
0
Forks
4
Merge médio
10h 16min
PRs com merge (30d)
2

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de TMHSDigital/Home-Lab-Developer-Tools

Todas as issues de TMHSDigital/Home-Lab-Developer-Tools

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.