ENH: Read NIfTI File should apply flipped axes from the stored transform

未关闭
#1,926 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 6 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
cpp
领域
data

调研方向

Start with ReadNiftiHeader and the voxel read in src/Plugins/ImageProcessing/src/ImageProcessing/utils/NiftiUtilities.cpp, then trace preflight and warning -34750 in ReadNIfTIFileFilter and review ReadNIfTIFileFilter.md. Check both the regular and out-of-core paths. The issue leaves the flip option, origin convention, and warning behavior undecided; those decisions must be settled before implementation, and done means flipped voxel order and geometry preserve the file's physical placement.

由索引模型根据 Issue 内容生成。

描述

enhancement

Summary

Request. With Use Stored Affine Transform on, Read NIfTI File (ReadNIfTIFileFilter) should apply an axis flip that the file stores. When the file gives a negative direction for an axis, the filter should reverse the voxel order along that axis and move the origin, so that the Image Geometry has the same physical placement and orientation as the file. Today the filter only warns about the flip.

Why it is needed. Many NIfTI files store a negative direction for one or more axes. The common LPS/RAS radiological conventions use a negative X or Y direction. The reader always uses positive spacing and loads the voxels in their stored order, so such an image is placed mirrored along that axis. A user who combines it with other data in physical coordinates, for example a mask or a second scan, gets data that does not line up. The warning tells the user about this, but the user must then flip the data with another filter and correct the origin by hand.

How it works now.

  • ReadNiftiHeader takes the spacing from the length of each sform column (always positive) and the origin from the translation column. For the qform, it uses the offsets as the origin and only checks the quaternion for a rotation. The sign of each axis is dropped.
  • PR #1911 (#1908 item L59) adds a flag for a flipped axis: a negative diagonal term in a used sform, qfac = -1 (pixdim[0] < 0) in a used qform, or a negative pixdim[1..3] when no sform is used. Preflight then gives warning -34750 ("contains negative direction values ... does not preserve these directions"). The geometry and the voxel order do not change.
  • A rotation in the transform is dropped too, with its own warning -34750 (ReadNIfTIFileFilter.cpp:279). Rotations are not part of this request.

Where it applies.

  • src/Plugins/ImageProcessing/src/ImageProcessing/utils/NiftiUtilities.cpp (ReadNiftiHeader and the voxel read).
  • ReadNIfTIFileFilter (preflight geometry values and warning -34750) and its documentation page ReadNIfTIFileFilter.md.
  • The out-of-core read path, because the voxel order along a flipped axis changes.

Open design points. Whether the flip is always applied or is a new option (and its default), which origin the flipped geometry gets (the physical position of the first voxel or of the voxel corner), and whether warning -34750 stays for the flip case are not decided yet.

主要语言
C++
星标
18
派生
15
平均合并
4 天 23 小时
30 天内合并 PR
42

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

BlueQuartzSoftware/simplnx 的其他 Issue

查看 BlueQuartzSoftware/simplnx 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。