ENH: Read NIfTI File should apply flipped axes from the stored transform
メンテナーはふだん 6 日以内に返信
まだ誰も着手していません。
評価
調査の方向性
Start with ReadNiftiHeader and the voxel read in src/Plugins/ImageProcessing/src/ImageProcessing/utils/NiftiUtilities.cpp, then trace preflight and warning -34750 in ReadNIfTIFileFilter and review ReadNIfTIFileFilter.md. Check both the regular and out-of-core paths. The issue leaves the flip option, origin convention, and warning behavior undecided; those decisions must be settled before implementation, and done means flipped voxel order and geometry preserve the file's physical placement.
索引モデルが issue の本文から書いたものです。
説明
Summary
Request. With Use Stored Affine Transform on, Read NIfTI File (ReadNIfTIFileFilter) should apply an axis flip that the file stores. When the file gives a negative direction for an axis, the filter should reverse the voxel order along that axis and move the origin, so that the Image Geometry has the same physical placement and orientation as the file. Today the filter only warns about the flip.
Why it is needed. Many NIfTI files store a negative direction for one or more axes. The common LPS/RAS radiological conventions use a negative X or Y direction. The reader always uses positive spacing and loads the voxels in their stored order, so such an image is placed mirrored along that axis. A user who combines it with other data in physical coordinates, for example a mask or a second scan, gets data that does not line up. The warning tells the user about this, but the user must then flip the data with another filter and correct the origin by hand.
How it works now.
ReadNiftiHeadertakes the spacing from the length of each sform column (always positive) and the origin from the translation column. For the qform, it uses the offsets as the origin and only checks the quaternion for a rotation. The sign of each axis is dropped.- PR #1911 (#1908 item L59) adds a flag for a flipped axis: a negative diagonal term in a used sform, qfac = -1 (
pixdim[0] < 0) in a used qform, or a negativepixdim[1..3]when no sform is used. Preflight then gives warning -34750 ("contains negative direction values ... does not preserve these directions"). The geometry and the voxel order do not change. - A rotation in the transform is dropped too, with its own warning -34750 (ReadNIfTIFileFilter.cpp:279). Rotations are not part of this request.
Where it applies.
src/Plugins/ImageProcessing/src/ImageProcessing/utils/NiftiUtilities.cpp(ReadNiftiHeaderand the voxel read).ReadNIfTIFileFilter(preflight geometry values and warning -34750) and its documentation pageReadNIfTIFileFilter.md.- The out-of-core read path, because the voxel order along a flipped axis changes.
Open design points. Whether the flip is always applied or is a new option (and its default), which origin the flipped geometry gets (the physical position of the first voxel or of the voxel corner), and whether warning -34750 stays for the flip case are not decided yet.
- 主要言語
- C++
- スター
- 18
- フォーク
- 15
- 平均マージ
- 4日 23時間
- マージ済み PR(30日)
- 42
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
BlueQuartzSoftware/simplnx のほかの issue
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
BlueQuartzSoftware/simplnx#1987 ·
メンテナーはふだん 6 日以内に返信
-
documentation
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
BlueQuartzSoftware/simplnx#1980 ·
メンテナーはふだん 6 日以内に返信
-
Testing
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
BlueQuartzSoftware/simplnx#1979 ·
メンテナーはふだん 6 日以内に返信
-
documentation
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
BlueQuartzSoftware/simplnx#1978 ·
メンテナーはふだん 6 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
BlueQuartzSoftware/simplnx#1945 ·
メンテナーはふだん 6 日以内に返信
BlueQuartzSoftware/simplnx の issue をすべて見る
似ている issue
-
bug triage
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
メンテナーはふだん 1 日以内に返信
-
26.04 bug dark-mode Easy Hack impress symptom: visual
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
CollaboraOnline/online#16421 · コメント 1 件 ·
-
area/cs bug
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
ydb-platform/ydb#59881 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 64/100
メンテナーはふだん 1 日以内に返信
-
documentation enhancement lua server
難易度 2/5 1〜3時間 初心者へのやさしさ 66/100