ENH: Read NIfTI File should apply flipped axes from the stored transform

Aperta
#1,926 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 6 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
cpp
Ambito
data

Direzione di ricerca

Start with ReadNiftiHeader and the voxel read in src/Plugins/ImageProcessing/src/ImageProcessing/utils/NiftiUtilities.cpp, then trace preflight and warning -34750 in ReadNIfTIFileFilter and review ReadNIfTIFileFilter.md. Check both the regular and out-of-core paths. The issue leaves the flip option, origin convention, and warning behavior undecided; those decisions must be settled before implementation, and done means flipped voxel order and geometry preserve the file's physical placement.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

Summary

Request. With Use Stored Affine Transform on, Read NIfTI File (ReadNIfTIFileFilter) should apply an axis flip that the file stores. When the file gives a negative direction for an axis, the filter should reverse the voxel order along that axis and move the origin, so that the Image Geometry has the same physical placement and orientation as the file. Today the filter only warns about the flip.

Why it is needed. Many NIfTI files store a negative direction for one or more axes. The common LPS/RAS radiological conventions use a negative X or Y direction. The reader always uses positive spacing and loads the voxels in their stored order, so such an image is placed mirrored along that axis. A user who combines it with other data in physical coordinates, for example a mask or a second scan, gets data that does not line up. The warning tells the user about this, but the user must then flip the data with another filter and correct the origin by hand.

How it works now.

  • ReadNiftiHeader takes the spacing from the length of each sform column (always positive) and the origin from the translation column. For the qform, it uses the offsets as the origin and only checks the quaternion for a rotation. The sign of each axis is dropped.
  • PR #1911 (#1908 item L59) adds a flag for a flipped axis: a negative diagonal term in a used sform, qfac = -1 (pixdim[0] < 0) in a used qform, or a negative pixdim[1..3] when no sform is used. Preflight then gives warning -34750 ("contains negative direction values ... does not preserve these directions"). The geometry and the voxel order do not change.
  • A rotation in the transform is dropped too, with its own warning -34750 (ReadNIfTIFileFilter.cpp:279). Rotations are not part of this request.

Where it applies.

  • src/Plugins/ImageProcessing/src/ImageProcessing/utils/NiftiUtilities.cpp (ReadNiftiHeader and the voxel read).
  • ReadNIfTIFileFilter (preflight geometry values and warning -34750) and its documentation page ReadNIfTIFileFilter.md.
  • The out-of-core read path, because the voxel order along a flipped axis changes.

Open design points. Whether the flip is always applied or is a new option (and its default), which origin the flipped geometry gets (the physical position of the first voxel or of the voxel corner), and whether warning -34750 stays for the flip case are not decided yet.

Lingua principale
C++
Stelle
18
Fork
15
Merge medio
4g 23h
PR unite (30g)
42

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di BlueQuartzSoftware/simplnx

Tutte le issue di BlueQuartzSoftware/simplnx

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.