Allow force-changing files using Shared Instances

未關閉
#8,145 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
48/100
Issue 類型
功能
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
rust
領域
desktop

研究方向

Start by reading pull request #7991 and its discussion of shared instance files, then trace how the Modrinth App selects and pushes files for an instance update. Check how joining or updating an instance handles files that already exist, and look for relevant tests in that flow. Done means an update can explicitly force selected shared files to replace existing files while preserving the current default behavior.

由索引模型根據 Issue 內容生成。

描述

Please confirm the following.
What parts of Modrinth is your feature request related too?

Modrinth App

Is your suggested feature related to a problem? Please describe.

Hi, as of 7991 it's now possible to share (almost) all files in the insance folder. Amazing work!

This pull request also mentions Players joining or updating a shared instance no longer download files they already have.
Unfortunatly this means that when I (as instance owner) want to change a setting from a mod it currently doesn't actually change it for other users.

Describe the solution you'd like

My suggestion is to add a force download file option when pushing a new update. This could be one simple checkbox when pushing an update. When you want to force 1 file but not all of them in a specific update, you can just push an update 2 times. Or maybe even add a second Force checkbox next to each file when selecting files to share.
I think the last option would be nicer but probably also a lot more work.

As the name implies, when this checkbox is checked the pushed files will override existing files.

I believe the default should stay as it is now, but a force download option would be amazing!

EDIT:
I was messing around and tried to push one file to a friend of mine and somehow it actuallty overrode the file... (it already existed on my friends instance)
I am confused... according to the the pull request that shouldn't happen?
If anyone knows what the current intended behaviour is I would love to know

Greetings, Werra

主要語言
Rust
星號
2.5k
分支
663
平均合併
2 天 11 小時
30 天內合併 PR
122

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

modrinth/code 的其他 Issue

查看 modrinth/code 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。