Allow force-changing files using Shared Instances

Aperta
  • Qualcosa non va?
#8,145 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
desktop

Direzione di ricerca

Start by reading pull request #7991 and its discussion of shared instance files, then trace how the Modrinth App selects and pushes files for an instance update. Check how joining or updating an instance handles files that already exist, and look for relevant tests in that flow. Done means an update can explicitly force selected shared files to replace existing files while preserving the current default behavior.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Please confirm the following.
What parts of Modrinth is your feature request related too?

Modrinth App

Is your suggested feature related to a problem? Please describe.

Hi, as of 7991 it's now possible to share (almost) all files in the insance folder. Amazing work!

This pull request also mentions Players joining or updating a shared instance no longer download files they already have.
Unfortunatly this means that when I (as instance owner) want to change a setting from a mod it currently doesn't actually change it for other users.

Describe the solution you'd like

My suggestion is to add a force download file option when pushing a new update. This could be one simple checkbox when pushing an update. When you want to force 1 file but not all of them in a specific update, you can just push an update 2 times. Or maybe even add a second Force checkbox next to each file when selecting files to share.
I think the last option would be nicer but probably also a lot more work.

As the name implies, when this checkbox is checked the pushed files will override existing files.

I believe the default should stay as it is now, but a force download option would be amazing!

EDIT:
I was messing around and tried to push one file to a friend of mine and somehow it actuallty overrode the file... (it already existed on my friends instance)
I am confused... according to the the pull request that shouldn't happen?
If anyone knows what the current intended behaviour is I would love to know

Greetings, Werra

Lingua principale
Rust
Stelle
2.5k
Fork
663
Merge medio
2g 11h
PR unite (30g)
122

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di modrinth/code

Tutte le issue di modrinth/code

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.