Allow force-changing files using Shared Instances

Aberta
  • Algo errado?
#8,145 1 comentário 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
48/100
Tipo de issue
Funcionalidade
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
rust
Domínio
desktop

Direção de pesquisa

Start by reading pull request #7991 and its discussion of shared instance files, then trace how the Modrinth App selects and pushes files for an instance update. Check how joining or updating an instance handles files that already exist, and look for relevant tests in that flow. Done means an update can explicitly force selected shared files to replace existing files while preserving the current default behavior.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Please confirm the following.
What parts of Modrinth is your feature request related too?

Modrinth App

Is your suggested feature related to a problem? Please describe.

Hi, as of 7991 it's now possible to share (almost) all files in the insance folder. Amazing work!

This pull request also mentions Players joining or updating a shared instance no longer download files they already have.
Unfortunatly this means that when I (as instance owner) want to change a setting from a mod it currently doesn't actually change it for other users.

Describe the solution you'd like

My suggestion is to add a force download file option when pushing a new update. This could be one simple checkbox when pushing an update. When you want to force 1 file but not all of them in a specific update, you can just push an update 2 times. Or maybe even add a second Force checkbox next to each file when selecting files to share.
I think the last option would be nicer but probably also a lot more work.

As the name implies, when this checkbox is checked the pushed files will override existing files.

I believe the default should stay as it is now, but a force download option would be amazing!

EDIT:
I was messing around and tried to push one file to a friend of mine and somehow it actuallty overrode the file... (it already existed on my friends instance)
I am confused... according to the the pull request that shouldn't happen?
If anyone knows what the current intended behaviour is I would love to know

Greetings, Werra

Linguagem predominante
Rust
Estrelas
2.5k
Forks
663
Merge médio
2d 11h
PRs com merge (30d)
122

Preparar o ambiente

Este projeto não oferece contêiner de desenvolvimento, Dockerfile nem guia de contribuição, então a configuração fica por sua conta: comece pelo README e veja nosso guia da primeira contribuição para os passos gerais.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de modrinth/code

Todas as issues de modrinth/code

Issues semelhantes

Mais issues de Rust

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.