Allow force-changing files using Shared Instances

Ouverte
  • Quelque chose ne va pas ?
#8,145 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
48/100
Type d'issue
Fonctionnalité
Clarté
Plutôt claire
Activité
Active
Stack technique
rust
Domaine
desktop

Piste de recherche

Start by reading pull request #7991 and its discussion of shared instance files, then trace how the Modrinth App selects and pushes files for an instance update. Check how joining or updating an instance handles files that already exist, and look for relevant tests in that flow. Done means an update can explicitly force selected shared files to replace existing files while preserving the current default behavior.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Please confirm the following.
What parts of Modrinth is your feature request related too?

Modrinth App

Is your suggested feature related to a problem? Please describe.

Hi, as of 7991 it's now possible to share (almost) all files in the insance folder. Amazing work!

This pull request also mentions Players joining or updating a shared instance no longer download files they already have.
Unfortunatly this means that when I (as instance owner) want to change a setting from a mod it currently doesn't actually change it for other users.

Describe the solution you'd like

My suggestion is to add a force download file option when pushing a new update. This could be one simple checkbox when pushing an update. When you want to force 1 file but not all of them in a specific update, you can just push an update 2 times. Or maybe even add a second Force checkbox next to each file when selecting files to share.
I think the last option would be nicer but probably also a lot more work.

As the name implies, when this checkbox is checked the pushed files will override existing files.

I believe the default should stay as it is now, but a force download option would be amazing!

EDIT:
I was messing around and tried to push one file to a friend of mine and somehow it actuallty overrode the file... (it already existed on my friends instance)
I am confused... according to the the pull request that shouldn't happen?
If anyone knows what the current intended behaviour is I would love to know

Greetings, Werra

Langage dominant
Rust
Étoiles
2.5k
Forks
663
Merge moyen
2 j 11 h
PR mergées (30 j)
122

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de modrinth/code

Toutes les issues de modrinth/code

Issues similaires

Plus d'issues Rust

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.