Tests for the start_recording startWhen/stopWhen arm path and its consent carry-over

未關閉
#349 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
1-2 天
新手友好度
70/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
typescript
領域
backend, testing

研究方向

Read src/tools/startRecording.ts around the listed arm and watcher paths, then inspect src/__tests__/startRecording.test.ts, src/__tests__/consentLogging.test.ts, and src/utils/triggers.ts. Extend the fake spawn tests with an elicitation capable client and mocked window and text checks, then run npm test. Done means the listed startWhen, consent carry-over, failed arm, and stopWhen cases pass.

由索引模型根據 Issue 內容生成。

描述

effort: medium priority: medium testing

Summary

armRecording asks for consent once at arm time, adds the args object to approvedAtArm, and later calls tool.handler(startArgs, ...). prepareStart skips the consent prompt when approvedAtArm.has(args). This relies on the handler receiving the very same object. watchStopWhen stops a session when OCR text appears. No test covers startWhen, stopWhen or approvedAtArm: triggers.test.ts covers only the utils. startRecording.ts is the highest-churn file and is at 47% lines / 34% branches locally.

Where

  • src/tools/startRecording.ts:237, 450-461, 466-511, 538, 654
  • src/__tests__/triggers.test.ts:41-54

Impact

If a refactor or the SDK clones args before the handler, armed recordings either re-prompt (and fail when no one is there) or, worse, a change to the WeakSet logic lets an unarmed call skip consent.

Suggested fix

Extend src/__tests__/startRecording.test.ts (fake spawn) with an elicitation-capable client (the pattern in src/__tests__/consentLogging.test.ts:76-77) and mocked window/text checks:

  • startWhen {}: isError "startWhen needs window and/or text."
  • startWhen {window}: status "armed" with an arm- id, and consent asked exactly once.
  • When the condition is met, a session starts through the same handler and the elicitation handler is not called a second time.
  • A plain start_recording after an arm still prompts (approval does not leak).
  • Consent declined at arm: isError, and no arm is registered.
  • fire() returning isError: arm status "failed" with that error text.
  • stopWhen text met: the session stops with the stopWhen reason; a session that ends first aborts the watcher.

Getting started

  • Relevant files: src/tools/startRecording.ts, src/utils/triggers.ts
  • How to run tests: npm test

Filed by repo-audit/full-audit at b9b94fa. Severity: medium. Effort: M. audit-key: testing|src/tools/startRecording.ts|armRecording

主要語言
TypeScript
星號
1
分支
4
平均合併
14 小時 8 分鐘
30 天內合併 PR
48

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

TMHSDigital/screencast-mcp 的其他 Issue

查看 TMHSDigital/screencast-mcp 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。