Allow an HTTP base_url for model providers, like OAC_PUBLIC_URL already does
維護者通常 1 天內回覆
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 25/100
- Issue 類型
- 功能
- 描述清晰度
- 描述清楚
- 活躍度
- 停滯
- 技術堆疊
- go
研究方向
Read contracts/agents-api/v1/model_provider_admission.go, especially providerScheme and validModelProviderBaseURL, and compare the private-host HTTP rules in internal/origin and deployment/public_url.go. Check the tests covering model provider base URL validation. Done means HTTP is accepted only for loopback or literal private ranges, HTTPS remains required elsewhere, and the linked pull request's behavior is covered by tests.
由索引模型根據 Issue 內容生成。
描述
What I'm asking for
Let a deployment default model provider be configured with an http:// base_url, instead of requiring https://.
Where it's blocked
contracts/agents-api/v1/model_provider_admission.go:12 hard-codes providerScheme = "https", and validModelProviderBaseURL rejects anything else. So PUT /core/v1/harnesses/{harness}/model-configuration returns 400 model_provider_base_url_invalid for a perfectly reachable local endpoint, e.g. http://127.0.0.1:7351 or http://10.0.0.5:8080.
This is a distinct surface from #398 / #408: those changed the public URL and the node paths. The model provider base_url keeps the unconditional HTTPS rule.
Why this looks inconsistent
The repo already treats plain HTTP as acceptable where it does not leave the trust boundary:
- #408 made
OAC_PUBLIC_URLaccepthttpon loopback and literal private ranges (internal/origin,deployment/public_url.go). - The model path's own credential gateway serves the Harness over loopback in plaintext by design (#343): the Harness never holds the key, so the relay is a local HTTP service.
The provider base_url is the one remaining surface that maps http to "invalid" unconditionally, even when the host is the same loopback the gateway already uses.
Concrete case, not hypothetical
I run a self-hosted model proxy on this host (an OpenAI / Anthropic / Responses-compatible gateway on 127.0.0.1:7351) and I want the Harnesses to use it. Today the only way through is to stand up a TLS terminator in front of it and install a self-signed CA into the Runtime image's trust store — extra moving parts for a connection that never leaves the machine.
Suggested shape
Accept http where the same rule the rest of Core already uses says it is safe — loopback, or literal private ranges — and keep https required everywhere else. That mirrors #408 exactly and keeps the current default unchanged. If you would rather make it explicit, an opt-in works too.
I am not asking to drop TLS. A plain-HTTP exception limited to loopback/private hosts would cover the local-proxy case without weakening anything reachable from the network.
- 主要語言
- Go
- 星號
- 182
- 分支
- 17
- 平均合併
- 1 小時 15 分鐘
- 30 天內合併 PR
- 360
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
MiniMax-AI/OpenAgentCore 的其他 Issue
-
Skip to content changes the console page to Overview可能已有人在做 @dvd233 於 3 天前認領。 未關閉
難度 3/5 1-2 天 新手友好度 35/100
MiniMax-AI/OpenAgentCore#421 ·
維護者通常 1 天內回覆
-
難度 5/5 一週以上 新手友好度 25/100
MiniMax-AI/OpenAgentCore#418 ·
維護者通常 1 天內回覆
-
難度 5/5 一週以上 新手友好度 20/100
MiniMax-AI/OpenAgentCore#397 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 5/5 一週以上 新手友好度 20/100
MiniMax-AI/OpenAgentCore#179 ·
維護者通常 1 天內回覆
查看 MiniMax-AI/OpenAgentCore 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 78/100
openimsdk/openim-sdk-core#1127 ·
-
github_actions
難度 2/5 1-3 小時 新手友好度 65/100
Hochfrequenz/aibap.mcp#578 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 85/100
mvanhorn/cli-printing-press#4980 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 62/100
lenaxia/LLMSafeSpaces#1644 · 3 則留言 · 1 個 reaction ·
維護者通常 1 天內回覆
-
automation code-quality cookie documentation improvement quick-win task-mining
難度 2/5 1-3 小時 新手友好度 65/100
維護者通常 1 天內回覆