Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

Allow an HTTP base_url for model providers, like OAC_PUBLIC_URL already does

Offen
  • Stimmt etwas nicht?
#416 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@velrith arbeitet bereits daran.

Seit 04.10.2026.

  • #417 von @velrith — offen

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
25/100
Issue-Typ
Feature
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
go
Bereich
backend-api-design

Rechercherichtung

Read contracts/agents-api/v1/model_provider_admission.go, especially providerScheme and validModelProviderBaseURL, and compare the private-host HTTP rules in internal/origin and deployment/public_url.go. Check the tests covering model provider base URL validation. Done means HTTP is accepted only for loopback or literal private ranges, HTTPS remains required elsewhere, and the linked pull request's behavior is covered by tests.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

What I'm asking for

Let a deployment default model provider be configured with an http:// base_url, instead of requiring https://.

Where it's blocked

contracts/agents-api/v1/model_provider_admission.go:12 hard-codes providerScheme = "https", and validModelProviderBaseURL rejects anything else. So PUT /core/v1/harnesses/{harness}/model-configuration returns 400 model_provider_base_url_invalid for a perfectly reachable local endpoint, e.g. http://127.0.0.1:7351 or http://10.0.0.5:8080.

This is a distinct surface from #398 / #408: those changed the public URL and the node paths. The model provider base_url keeps the unconditional HTTPS rule.

Why this looks inconsistent

The repo already treats plain HTTP as acceptable where it does not leave the trust boundary:

  • #408 made OAC_PUBLIC_URL accept http on loopback and literal private ranges (internal/origin, deployment/public_url.go).
  • The model path's own credential gateway serves the Harness over loopback in plaintext by design (#343): the Harness never holds the key, so the relay is a local HTTP service.

The provider base_url is the one remaining surface that maps http to "invalid" unconditionally, even when the host is the same loopback the gateway already uses.

Concrete case, not hypothetical

I run a self-hosted model proxy on this host (an OpenAI / Anthropic / Responses-compatible gateway on 127.0.0.1:7351) and I want the Harnesses to use it. Today the only way through is to stand up a TLS terminator in front of it and install a self-signed CA into the Runtime image's trust store — extra moving parts for a connection that never leaves the machine.

Suggested shape

Accept http where the same rule the rest of Core already uses says it is safe — loopback, or literal private ranges — and keep https required everywhere else. That mirrors #408 exactly and keeps the current default unchanged. If you would rather make it explicit, an opt-in works too.

I am not asking to drop TLS. A plain-HTTP exception limited to loopback/private hosts would cover the local-proxy case without weakening anything reachable from the network.

Vorherrschende Sprache
Go
Sterne
182
Forks
17
Ø Merge
1 Std. 15 Min.
Gemergte PRs (30 T.)
360

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus MiniMax-AI/OpenAgentCore

Alle Issues in MiniMax-AI/OpenAgentCore

Ähnliche Issues

Weitere Issues zu Go

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.