Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Allow an HTTP base_url for model providers, like OAC_PUBLIC_URL already does

Aperta
  • Qualcosa non va?
#416 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@velrith ci sta già lavorando.

Dal 4/10/2026.

  • #417 di @velrith — aperta

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
go
Ambito
backend-api-design

Direzione di ricerca

Read contracts/agents-api/v1/model_provider_admission.go, especially providerScheme and validModelProviderBaseURL, and compare the private-host HTTP rules in internal/origin and deployment/public_url.go. Check the tests covering model provider base URL validation. Done means HTTP is accepted only for loopback or literal private ranges, HTTPS remains required elsewhere, and the linked pull request's behavior is covered by tests.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

What I'm asking for

Let a deployment default model provider be configured with an http:// base_url, instead of requiring https://.

Where it's blocked

contracts/agents-api/v1/model_provider_admission.go:12 hard-codes providerScheme = "https", and validModelProviderBaseURL rejects anything else. So PUT /core/v1/harnesses/{harness}/model-configuration returns 400 model_provider_base_url_invalid for a perfectly reachable local endpoint, e.g. http://127.0.0.1:7351 or http://10.0.0.5:8080.

This is a distinct surface from #398 / #408: those changed the public URL and the node paths. The model provider base_url keeps the unconditional HTTPS rule.

Why this looks inconsistent

The repo already treats plain HTTP as acceptable where it does not leave the trust boundary:

  • #408 made OAC_PUBLIC_URL accept http on loopback and literal private ranges (internal/origin, deployment/public_url.go).
  • The model path's own credential gateway serves the Harness over loopback in plaintext by design (#343): the Harness never holds the key, so the relay is a local HTTP service.

The provider base_url is the one remaining surface that maps http to "invalid" unconditionally, even when the host is the same loopback the gateway already uses.

Concrete case, not hypothetical

I run a self-hosted model proxy on this host (an OpenAI / Anthropic / Responses-compatible gateway on 127.0.0.1:7351) and I want the Harnesses to use it. Today the only way through is to stand up a TLS terminator in front of it and install a self-signed CA into the Runtime image's trust store — extra moving parts for a connection that never leaves the machine.

Suggested shape

Accept http where the same rule the rest of Core already uses says it is safe — loopback, or literal private ranges — and keep https required everywhere else. That mirrors #408 exactly and keeps the current default unchanged. If you would rather make it explicit, an opt-in works too.

I am not asking to drop TLS. A plain-HTTP exception limited to loopback/private hosts would cover the local-proxy case without weakening anything reachable from the network.

Lingua principale
Go
Stelle
210
Fork
29
Merge medio
1h 12m
PR unite (30g)
588

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di MiniMax-AI/OpenAgentCore

Tutte le issue di MiniMax-AI/OpenAgentCore

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.