Allow an HTTP base_url for model providers, like OAC_PUBLIC_URL already does
维护者通常 1 天内回复
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 25/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 停滞
- 技术栈
- go
调研方向
Read contracts/agents-api/v1/model_provider_admission.go, especially providerScheme and validModelProviderBaseURL, and compare the private-host HTTP rules in internal/origin and deployment/public_url.go. Check the tests covering model provider base URL validation. Done means HTTP is accepted only for loopback or literal private ranges, HTTPS remains required elsewhere, and the linked pull request's behavior is covered by tests.
由索引模型根据 Issue 内容生成。
描述
What I'm asking for
Let a deployment default model provider be configured with an http:// base_url, instead of requiring https://.
Where it's blocked
contracts/agents-api/v1/model_provider_admission.go:12 hard-codes providerScheme = "https", and validModelProviderBaseURL rejects anything else. So PUT /core/v1/harnesses/{harness}/model-configuration returns 400 model_provider_base_url_invalid for a perfectly reachable local endpoint, e.g. http://127.0.0.1:7351 or http://10.0.0.5:8080.
This is a distinct surface from #398 / #408: those changed the public URL and the node paths. The model provider base_url keeps the unconditional HTTPS rule.
Why this looks inconsistent
The repo already treats plain HTTP as acceptable where it does not leave the trust boundary:
- #408 made
OAC_PUBLIC_URLaccepthttpon loopback and literal private ranges (internal/origin,deployment/public_url.go). - The model path's own credential gateway serves the Harness over loopback in plaintext by design (#343): the Harness never holds the key, so the relay is a local HTTP service.
The provider base_url is the one remaining surface that maps http to "invalid" unconditionally, even when the host is the same loopback the gateway already uses.
Concrete case, not hypothetical
I run a self-hosted model proxy on this host (an OpenAI / Anthropic / Responses-compatible gateway on 127.0.0.1:7351) and I want the Harnesses to use it. Today the only way through is to stand up a TLS terminator in front of it and install a self-signed CA into the Runtime image's trust store — extra moving parts for a connection that never leaves the machine.
Suggested shape
Accept http where the same rule the rest of Core already uses says it is safe — loopback, or literal private ranges — and keep https required everywhere else. That mirrors #408 exactly and keeps the current default unchanged. If you would rather make it explicit, an opt-in works too.
I am not asking to drop TLS. A plain-HTTP exception limited to loopback/private hosts would cover the local-proxy case without weakening anything reachable from the network.
- 主要语言
- Go
- 星标
- 182
- 派生
- 17
- 平均合并
- 1 小时 15 分钟
- 30 天内合并 PR
- 360
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
MiniMax-AI/OpenAgentCore 的其他 Issue
-
Skip to content changes the console page to Overview可能已有人在做 @dvd233 于 3 天前认领。 未关闭
难度 3/5 1-2 天 新手友好度 35/100
MiniMax-AI/OpenAgentCore#421 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 25/100
MiniMax-AI/OpenAgentCore#418 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 20/100
MiniMax-AI/OpenAgentCore#397 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 20/100
MiniMax-AI/OpenAgentCore#179 ·
维护者通常 1 天内回复
查看 MiniMax-AI/OpenAgentCore 的全部 Issue
相似的 Issue
-
Idle compaction monitors LIST the replica every tick when the newest destination file spans more than one TXID可能已有人在做 @pishuv 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
benbjohnson/litestream#1563 ·
维护者通常 2 天内回复
-
难度 1/5 1 小时以内 新手友好度 88/100
维护者通常 1 天内回复
-
agent-research agent-review-finding chore
难度 2/5 1-3 小时 新手友好度 66/100
jordansmall/spindrift#4922 ·
维护者通常 1 天内回复
-
gcsartifact: deleting a missing version returns an error可能已有人在做 @ktsoator 今天认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 2 天内回复
-
govulncheck
难度 2/5 1-3 小时 新手友好度 62/100
维护者通常 1 天内回复