Generic string to simulate stats amounts with durations and starting points

Open
#5,945 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
backend

Research direction

Start by reading how the existing APL option external_buffs.power_infusion is parsed and applied. Then determine how a generic stat amount, percent-or-raw value, duration, and combat start time could fit that flow; done means the requested configurable effect can be used from an APL and tested across the stated timing and amount options.

Written by the indexing model from the issue text.

Description

Usability
Is your feature request related to a problem? Please describe.

Blizzard has been implementing a lot of stat bonuses built into cooldowns or legendary effects based on when an ability is cast. I always want to try and utilize them in the best way I can on PTR. Having a generic string where you can give a stat amount (percent or raw) with a set duration and when in combat to start it would be really helpful for a number of reasons. Firstly it would be something usable for a number of different buffs and effects and multipurpose. Secondly if the ability is getting tuned constantly, rather than having to rework an implemented string, if the string were already implemented for PTR, there would be no adjustment needed. Finally it could serve as a framework for strings when whatever buff you want to implement does hit live servers with final testing.

Describe the solution you'd like

Just some generic string that could be put into an APL, similar to how external_buffs.power_infusion="#" works.
Something like external_buffs.generic_stat="StatType/SpecifyPercentorRaw/Amount/Duration/StartTimes"

Describe alternatives you've considered

The way we simulated things without their implementation, such as warrior banner, were to use enchants and run a short sim to see relative gain per class, however you can only really test on pull with this.

Dominant language
C++
Stars
1.6k
Forks
789
Avg merge
13h 25m
Merged PRs (30d)
52

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from simulationcraft/simc

All issues in simulationcraft/simc

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.