Timewalking Item Level Bug
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
The issue links to simulationcraft/simc-addon#70 and identifies ItemScalingConfig.flags as a possible avenue, but says the clamp behavior is unconfirmed. Start by reading that linked report and locating the item-level scaling and clamp logic around ItemScalingConfig; verify the timewalking cases before changing anything. Done means timewalking items simulate at the correct item levels without breaking other scaling behavior, with tests covering the affected cases.
Written by the indexing model from the issue text.
Description
https://github.com/simulationcraft/simc-addon/issues/70
Looks like some time walking items are being simmed too low. I believe there's an item level clamp being applied that shouldn't be. ItemScalingConfig.flags is a possible avenue to enable/disable this clamp to get correct item levels but I haven't fully confirmed that.
- Dominant language
- C++
- Stars
- 1.6k
- Forks
- 789
- Avg merge
- 13h 25m
- Merged PRs (30d)
- 52
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from simulationcraft/simc
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
simulationcraft/simc#11973 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
simulationcraft/simc#11747 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
simulationcraft/simc#11935 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
simulationcraft/simc#11918 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
simulationcraft/simc#11752 · 1 comment ·
Maintainers usually reply within 1 day
All issues in simulationcraft/simc
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
eclipse-score/lifecycle#929 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
colbymchenry/codegraph#3223 ·
Maintainers usually reply within 1 day