Guardian Druid: Moonfire should not reset swing timer
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
The suspected cause is that druid_spell_base_t treats Moonfire as a GCD-triggering spell when checking trigger_gcd > 0, which resets the swing timer. Start from that base class and the swing-timer reset path it reaches, then compare with the attached moonfire_on and moonfire_off logs. Done means Moonfire no longer resets auto attacks in those logs, and Swipe and Moonfire rotations show the same auto-attack count as before.
Written by the indexing model from the issue text.
Description
Describe the bug
When using Lunation, the APL switches to an extended use of moonfire. This has been observed to reduce the amount of auto attacks.
A first analysis as shown that moonfire might reset the swing timer, as it derives from druid_spell_base_t which checks for trigger_gcd > 0.
Expected behavior
Using moonfire over swipe should not influence the auto attack speed and should not reset the swing timer as it does not represent actual game behavior.
To Reproduce
moonfire off, auto attack is being executed:
moonfire_off.txt
moonfire on (only moonfire), no auto attacks are being executed at all:
moonfire_on.txt
Additional information
- SimulationCraft Version simc-1210.01.d08a1c3-win64
- Dominant language
- C++
- Stars
- 1.6k
- Forks
- 789
- Avg merge
- 13h 25m
- Merged PRs (30d)
- 52
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from simulationcraft/simc
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
simulationcraft/simc#11973 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
simulationcraft/simc#11747 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
simulationcraft/simc#11918 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
simulationcraft/simc#11845 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
simulationcraft/simc#11752 · 1 comment ·
Maintainers usually reply within 1 day
All issues in simulationcraft/simc
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
eclipse-score/lifecycle#929 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
colbymchenry/codegraph#3223 ·
Maintainers usually reply within 1 day