report_running(): C++ variant discards the Result

Closed Beginner friendly
  • Is something wrong?
#929 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp
Domain
infrastructure

Research direction

The bug is in score/launch_manager/src/lifecycle_client/src/report_running.cpp around line 19, where the result of ReportRunningState() is discarded. Read the C variant of report_running in the same lifecycle client to see how it reports failure (it returns -1), then make the C++ function pass the failure back to its caller. Done when a failing ReportRunningState() reaches the caller, which you can check with a test that forces that failure.

Written by the indexing model from the issue text.

Description

score::mw::lifecycle::report_running() drops the ReportRunningState() result, so callers can't detect failure; the C variant returns -1.
https://github.com/eclipse-score/lifecycle/blob/b7cd5f7c33177bf7a28b17196bc5efc5d2ea6da3/score/launch_manager/src/lifecycle_client/src/report_running.cpp#L19

Dominant language
C++
Stars
7
Forks
37
Avg merge
2d 9h
Merged PRs (30d)
117

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from eclipse-score/lifecycle

All issues in eclipse-score/lifecycle

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.