bug: get_run_details has returned a non-progressing zero-limit cursor since PR #3224

Aberta Para iniciantes
  • Algo errado?
#4,733 4 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

@AbhayPratap01 já está trabalhando nisso.

Desde 25/8/2026.

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
68/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
typescript
Domínio
api

Direção de pesquisa

Comece em packages/cli-v3/src/mcp/schemas.ts (GetRunDetailsInput, maxTraceLines não tem mínimo) e packages/cli-v3/src/mcp/tools/runs.ts, onde readLinesPage calcula nextCursor como offset + limit. Adicione uma restrição de inteiro positivo ao schema mais uma verificação defensiva em readLinesPage, de modo que um limite zero/negativo ou retorne um erro ou devolva um cursor que avance. Verifique com os testes existentes das ferramentas MCP do cli-v3, acrescentando casos para maxTraceLines 0, um valor negativo e 1 para confirmar que nextCursor progride de "0" para "1".

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Provide environment information

System:
  OS: macOS 26.5.2
  CPU: (10) arm64 Apple M4
  Memory: 1.82 GB / 16.00 GB
  Shell: 5.9 - /bin/zsh
Binaries:
  Node: 24.19.0
  npm: 11.7.0
  pnpm: 11.19.0
  bun: 1.3.14
Trigger.dev:
  CLI and SDK: 4.5.11
  MCP transport: stdio
  Flags: --dev-only --readonly
  Environment: dev

Describe the bug

The MCP get_run_details tool accepts maxTraceLines: 0 and reports a
successful empty page with nextCursor: "0". Following that cursor requests
the same page again, so pagination cannot advance.

I found this while testing Trigger.dev's MCP surface with an internal agent
compatibility system at Bottomless. The reproduction is model-free and uses a
dedicated benchmark dev project.

Expected behavior: reject a page size below one, or return a cursor that
advances.

Actual behavior:

Run Trace (lines 1-0 of 43)
More trace available.
nextCursor: "0"

To reproduce

  1. Start the official Trigger.dev MCP for a project that has a completed dev
    run.
  2. Call get_run_details for that run with maxTraceLines: 0.
  3. Observe that the call succeeds, reports lines 1-0, and returns cursor
    "0" while saying more trace is available.
  4. Call the tool again with cursor "0"; it returns the same page.

Reduced arguments:

{
  "projectRef": "<project-ref>",
  "environment": "dev",
  "runId": "<completed-run-id>",
  "maxTraceLines": 0
}

A control call with maxTraceLines: 1 returns lines 1-1 and cursor "1".

Additional information

I traced the behavior through Main history. The non-progressing cursor path was
introduced by PR #3224,
feat(cli): Expand and improve the MCP server and dev CLI command, merged on
March 17, 2026 at commit
dbbe9f77f953ad7a8306e48d7bd1107e3f8d3ba2.

Before that PR, maxTraceLines existed but get_run_details did not return a
cursor. PR #3224 added cursor pagination while leaving the zero value valid.
Its new readLinesPage function computed nextCursor as offset + limit, so
a zero limit returned the same cursor indefinitely.

The schema still accepted every integer when I rechecked Main on August 20,
2026 at 447471843cbe7759f64beb616d5db5f05696ea13, because maxTraceLines has
no minimum:

https://github.com/triggerdotdev/trigger.dev/blob/447471843cbe7759f64beb616d5db5f05696ea13/packages/cli-v3/src/mcp/schemas.ts#L146-L160

The same cursor calculation also remains on current Main:

https://github.com/triggerdotdev/trigger.dev/blob/447471843cbe7759f64beb616d5db5f05696ea13/packages/cli-v3/src/mcp/tools/runs.ts#L35-L52

Suggested change: require a positive integer in GetRunDetailsInput, add a
defensive positive-limit check in readLinesPage, and cover zero/negative
limits plus a one-line positive case in tests.

The live check had zero invalid cases, unchanged fixture state, and verified
cleanup. Searches of existing issues and PRs found no matching report. This is
an MCP response-contract issue, not a security report.

We are testing a system at Bottomless that runs repeatable MCP contract and
workflow checks, verifies the observed behavior directly, and can replay the
same checks when an MCP changes. We are trying to learn whether MCP teams would
want checks like this on future pull requests or releases. Would that be useful
to your team?

If useful, I can look into a focused regression test and fix, then rerun the
same check.

Linguagem predominante
TypeScript
Estrelas
16.5k
Forks
1.5k
Merge médio
1d 15h
PRs com merge (30d)
17

Preparar o ambiente

Este projeto não oferece contêiner de desenvolvimento, Dockerfile nem guia de contribuição, então a configuração fica por sua conta: comece pelo README e veja nosso guia da primeira contribuição para os passos gerais.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de triggerdotdev/trigger.dev

Todas as issues de triggerdotdev/trigger.dev

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.