Backup and state folders are written through junctions without a check
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 62/100
Research direction
Start with Target() and the reparse-point check in clean/installer/src/wg_core/record.cpp, then read StateDir/BackupPath there and DoInstall at install.cpp:582-589, where EnsureDir and CopyChecked run. Add one helper that refuses when the state folder or its backup, previous and rr-config subfolders is a reparse point, and call it before the first write; RemoveTree in util.cpp already handles reparse points. Done when the core test with a junctioned backup folder is refused and the sentinel wronggpu.ini keeps its bytes.
Written by the indexing model from the issue text.
Description
This was found by reading the code. It has not been reproduced.
What happens
Target() refuses reparse points on every path component below the game folder (clean/installer/src/wg_core/record.cpp:171-188). The state folder is not checked. StateDir and BackupPath are a plain Join (record.cpp:21-23). DoInstall creates the state folder with EnsureDir(state) (clean/installer/src/wg_core/install.cpp:582). EnsureDir accepts an existing junction as a folder (clean/installer/src/wg_core/util.cpp:108-110). Backups are then written with CopyChecked(Target(...), BackupPath(...)) (install.cpp:588), which overwrites the destination (util.cpp:146-149). Nothing checks wronggpu-setup, wronggpu-setup\backup, previous\ or rr-config\ for reparse points. The same holds for SaveRecord, the uninstaller copy and profile.ini. The hash check at install.cpp:589 only checks the new copy.
So if one of those folders is a junction, a backup is written into the junction's target and can overwrite a file there.
When it can happen
Not for an ordinary player. WrongGPU creates wronggpu-setup itself and nothing makes it a junction. An unusual but innocent case: a player moved wronggpu-setup to another drive with mklink /J, then installed fresh while the target folder held files with matching names. Another program with write access to the game folder could plant a junction, but it could damage those files directly anyway.
This does not cross a privilege boundary. The elevated path is used only when the player cannot write the game folder. Planting a junction there already needs the rights that elevation grants. In a folder the player can write, no elevation happens. Low severity. Losing a file is the worst outcome, so this is worth hardening, but it is not a reachable path to data loss.
To do
- Add one helper. Before the first write, and in every operation that writes to the state folder, refuse if
StateDir(dir)orStateDir(dir)\backup(andprevious,rr-config) exists and is a reparse point. RemoveTreealready handles reparse points (util.cpp:153-155).- Caution: none for normal installs. A player who moved the folder with a junction on purpose gets a clear refusal.
Test
CPU-only. Make a temporary game folder with wronggpu-setup\backup as a junction to a folder holding a sentinel wronggpu.ini, plus a game wronggpu.ini. Run the install from the core tests. Assert it refuses and the sentinel's bytes are unchanged.
- Dominant language
- C++
- Stars
- 12
- Forks
- 2
- Avg merge
- 3h 10m
- Merged PRs (30d)
- 171
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from phantoslayer21/wronggpu
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
phantoslayer21/wronggpu#275 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
phantoslayer21/wronggpu#274 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
phantoslayer21/wronggpu#241 ·
Maintainers usually reply within 1 day
-
bug build
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
phantoslayer21/wronggpu#234 ·
Maintainers usually reply within 1 day
-
bug build
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
phantoslayer21/wronggpu#233 ·
Maintainers usually reply within 1 day
All issues in phantoslayer21/wronggpu
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
ReyeMe/SaturnRingLib#155 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Nheko-Reborn/nheko#2092 ·
-
Difficulty 1/5 1-3 hours Newbie friendliness 78/100
isocpp/CppCoreGuidelines#2345 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 71/100
ROCm/rocm-libraries#16108 ·
Maintainers usually reply within 2 days