Backup and state folders are written through junctions without a check
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Start with Target() and the reparse-point check in clean/installer/src/wg_core/record.cpp, then read StateDir/BackupPath there and DoInstall at install.cpp:582-589, where EnsureDir and CopyChecked run. Add one helper that refuses when the state folder or its backup, previous and rr-config subfolders is a reparse point, and call it before the first write; RemoveTree in util.cpp already handles reparse points. Done when the core test with a junctioned backup folder is refused and the sentinel wronggpu.ini keeps its bytes.
由索引模型根據 Issue 內容生成。
描述
This was found by reading the code. It has not been reproduced.
What happens
Target() refuses reparse points on every path component below the game folder (clean/installer/src/wg_core/record.cpp:171-188). The state folder is not checked. StateDir and BackupPath are a plain Join (record.cpp:21-23). DoInstall creates the state folder with EnsureDir(state) (clean/installer/src/wg_core/install.cpp:582). EnsureDir accepts an existing junction as a folder (clean/installer/src/wg_core/util.cpp:108-110). Backups are then written with CopyChecked(Target(...), BackupPath(...)) (install.cpp:588), which overwrites the destination (util.cpp:146-149). Nothing checks wronggpu-setup, wronggpu-setup\backup, previous\ or rr-config\ for reparse points. The same holds for SaveRecord, the uninstaller copy and profile.ini. The hash check at install.cpp:589 only checks the new copy.
So if one of those folders is a junction, a backup is written into the junction's target and can overwrite a file there.
When it can happen
Not for an ordinary player. WrongGPU creates wronggpu-setup itself and nothing makes it a junction. An unusual but innocent case: a player moved wronggpu-setup to another drive with mklink /J, then installed fresh while the target folder held files with matching names. Another program with write access to the game folder could plant a junction, but it could damage those files directly anyway.
This does not cross a privilege boundary. The elevated path is used only when the player cannot write the game folder. Planting a junction there already needs the rights that elevation grants. In a folder the player can write, no elevation happens. Low severity. Losing a file is the worst outcome, so this is worth hardening, but it is not a reachable path to data loss.
To do
- Add one helper. Before the first write, and in every operation that writes to the state folder, refuse if
StateDir(dir)orStateDir(dir)\backup(andprevious,rr-config) exists and is a reparse point. RemoveTreealready handles reparse points (util.cpp:153-155).- Caution: none for normal installs. A player who moved the folder with a junction on purpose gets a clear refusal.
Test
CPU-only. Make a temporary game folder with wronggpu-setup\backup as a junction to a folder holding a sentinel wronggpu.ini, plus a game wronggpu.ini. Run the install from the core tests. Assert it refuses and the sentinel's bytes are unchanged.
- 主要語言
- C++
- 星號
- 12
- 分支
- 2
- 平均合併
- 3 小時 10 分鐘
- 30 天內合併 PR
- 171
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
phantoslayer21/wronggpu 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 88/100
phantoslayer21/wronggpu#275 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 82/100
phantoslayer21/wronggpu#274 ·
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 88/100
phantoslayer21/wronggpu#241 ·
維護者通常 1 天內回覆
-
bug build
難度 2/5 1-3 小時 新手友好度 74/100
phantoslayer21/wronggpu#234 ·
維護者通常 1 天內回覆
-
bug build
難度 2/5 1-3 小時 新手友好度 80/100
phantoslayer21/wronggpu#233 ·
維護者通常 1 天內回覆
查看 phantoslayer21/wronggpu 的全部 Issue
相似的 Issue
-
ai_p2
難度 2/5 1-3 小時 新手友好度 80/100
ClickHouse/ClickHouse#132519 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 76/100
juce-framework/JUCE#1810 ·
-
難度 1/5 1 小時以內 新手友好度 82/100
petercorke/robotics-toolbox-python#952 ·
維護者通常 1 天內回覆
-
NatronRenderer: a Python error in the script (-t / project script) doesn't change the exit status未關閉func:engine type:bug
難度 2/5 1-3 小時 新手友好度 72/100
NatronGitHub/Natron#1276 ·
維護者通常 1 天內回覆
-
難度 1/5 1-3 小時 新手友好度 77/100
維護者通常 1 天內回覆