Backup and state folders are written through junctions without a check
Mantenedores costumam responder em até 1 dia
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 3/5
- Tempo estimado
- 1-2 dias
- Facilidade para iniciantes
- 62/100
Direção de pesquisa
Start with Target() and the reparse-point check in clean/installer/src/wg_core/record.cpp, then read StateDir/BackupPath there and DoInstall at install.cpp:582-589, where EnsureDir and CopyChecked run. Add one helper that refuses when the state folder or its backup, previous and rr-config subfolders is a reparse point, and call it before the first write; RemoveTree in util.cpp already handles reparse points. Done when the core test with a junctioned backup folder is refused and the sentinel wronggpu.ini keeps its bytes.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
This was found by reading the code. It has not been reproduced.
What happens
Target() refuses reparse points on every path component below the game folder (clean/installer/src/wg_core/record.cpp:171-188). The state folder is not checked. StateDir and BackupPath are a plain Join (record.cpp:21-23). DoInstall creates the state folder with EnsureDir(state) (clean/installer/src/wg_core/install.cpp:582). EnsureDir accepts an existing junction as a folder (clean/installer/src/wg_core/util.cpp:108-110). Backups are then written with CopyChecked(Target(...), BackupPath(...)) (install.cpp:588), which overwrites the destination (util.cpp:146-149). Nothing checks wronggpu-setup, wronggpu-setup\backup, previous\ or rr-config\ for reparse points. The same holds for SaveRecord, the uninstaller copy and profile.ini. The hash check at install.cpp:589 only checks the new copy.
So if one of those folders is a junction, a backup is written into the junction's target and can overwrite a file there.
When it can happen
Not for an ordinary player. WrongGPU creates wronggpu-setup itself and nothing makes it a junction. An unusual but innocent case: a player moved wronggpu-setup to another drive with mklink /J, then installed fresh while the target folder held files with matching names. Another program with write access to the game folder could plant a junction, but it could damage those files directly anyway.
This does not cross a privilege boundary. The elevated path is used only when the player cannot write the game folder. Planting a junction there already needs the rights that elevation grants. In a folder the player can write, no elevation happens. Low severity. Losing a file is the worst outcome, so this is worth hardening, but it is not a reachable path to data loss.
To do
- Add one helper. Before the first write, and in every operation that writes to the state folder, refuse if
StateDir(dir)orStateDir(dir)\backup(andprevious,rr-config) exists and is a reparse point. RemoveTreealready handles reparse points (util.cpp:153-155).- Caution: none for normal installs. A player who moved the folder with a junction on purpose gets a clear refusal.
Test
CPU-only. Make a temporary game folder with wronggpu-setup\backup as a junction to a folder holding a sentinel wronggpu.ini, plus a game wronggpu.ini. Run the install from the core tests. Assert it refuses and the sentinel's bytes are unchanged.
- Linguagem predominante
- C++
- Estrelas
- 12
- Forks
- 2
- Merge médio
- 3h 10min
- PRs com merge (30d)
- 171
Preparar o ambiente
- Sem Dockerfile nem arquivo Docker Compose
- Tem um modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de phantoslayer21/wronggpu
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 88/100
phantoslayer21/wronggpu#275 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 82/100
phantoslayer21/wronggpu#274 ·
Mantenedores costumam responder em até 1 dia
-
bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 88/100
phantoslayer21/wronggpu#241 ·
Mantenedores costumam responder em até 1 dia
-
bug build
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 74/100
phantoslayer21/wronggpu#234 ·
Mantenedores costumam responder em até 1 dia
-
Launcher tests: "an older record: update available" fakes a version newer than the test buildAbertabug build
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 80/100
phantoslayer21/wronggpu#233 ·
Mantenedores costumam responder em até 1 dia
Todas as issues de phantoslayer21/wronggpu
Issues semelhantes
-
ai_p2
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 80/100
ClickHouse/ClickHouse#132519 ·
Mantenedores costumam responder em até 1 dia
-
[Bug]: VST3 getMidiControllerAssignment reads past midiControllerToParameter for program changeAberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
juce-framework/JUCE#1810 ·
-
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 82/100
petercorke/robotics-toolbox-python#952 ·
Mantenedores costumam responder em até 1 dia
-
NatronRenderer: a Python error in the script (-t / project script) doesn't change the exit statusAbertafunc:engine type:bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
NatronGitHub/Natron#1276 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 1/5 1-3 horas Facilidade para iniciantes 77/100
Mantenedores costumam responder em até 1 dia