Launcher suite: two uninstall checks fail on main (RR settings after an in-game edit, RE9 mirror)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 28/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Domain
- build-system, testing
Research direction
Run tests/run_launcher_tests.py to reproduce test_rr and test_re9, then read how repair records WrongGPU\wronggpu.ini: the move from copy 0 to copy 1 <sha> is what makes the final uninstall treat the file as another setup's. For test_re9, trace where _storage_\dxgi.dll is meant to be removed during update and uninstall. Also check main()'s synth_f argument (passed only to rr) and clean/linux/run_wine_tests.py, which builds only unit tests. Done means both checks pass on main, or are shown stale and updated.
Written by the indexing model from the issue text.
Description
Two checks of tests/run_launcher_tests.py fail on main (9ef4da7). Found while merging main into the native Linux launcher branch; both reproduce the same way with main's own launcher (MinGW WRONGGPU_TESTING build, -DWRONGGPU_PRESET_K=OFF) under Wine (GE-Proton 11-11). Not run on Windows, so it is possible the checks rather than the code are out of date.
1. test_rr: "uninstall: exit 0, the RR game's folder as before except the two RR settings files the plugin rewrote..."
After the suite edits WrongGPU\wronggpu.ini as the plugin would (rr_mode = fast, rr_overlay=1), the next repair records that file as the player's: its record line goes from copy 0 - <inst> to copy 1 <sha of the edited file> <inst> ("Backed up and replaced"). The final uninstall then says it is "partly" done (WrongGPU\wronggpu.ini is now another setup's OptiScaler) and leaves WrongGPU-originals\<stamp>\WrongGPU\wronggpu.ini behind, which the check does not expect.
2. test_re9: "uninstall after the update: everything of WrongGPU's gone from the folder and the mirror; the player's mirrored file stays"
_storage_\dxgi.dll (sha256 6c66d3d8...) is left after the update and uninstall.
Also
- The
WrongGPUtarget no longer builds with llvm-mingw 20261104:WICBitmapInterpolationModeHighQualityCubic,D2D1_GAUSSIANBLUR_OPTIMIZATION_QUALITY,UIA_ScrollPatternNoScrolland the__uuidofof two UI Automation interfaces are missing from its headers.clean/linux/run_wine_tests.pybuilds only the unit tests, so it does not catch this. MinGW is for testing only, so this may not matter to you. --only re9fails at the call:main()passessynth_fonly torr.
- Dominant language
- C++
- Stars
- 12
- Forks
- 2
- Avg merge
- 3h 10m
- Merged PRs (30d)
- 171
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from phantoslayer21/wronggpu
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
phantoslayer21/wronggpu#275 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
phantoslayer21/wronggpu#274 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
phantoslayer21/wronggpu#241 ·
Maintainers usually reply within 1 day
-
bug build
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
phantoslayer21/wronggpu#234 ·
Maintainers usually reply within 1 day
-
bug build
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
phantoslayer21/wronggpu#233 ·
Maintainers usually reply within 1 day
All issues in phantoslayer21/wronggpu
Similar issues
-
ai_p2
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
ClickHouse/ClickHouse#132519 ·
Maintainers usually reply within 1 day
-
[Bug]: VST3 getMidiControllerAssignment reads past midiControllerToParameter for program changeOpen
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
juce-framework/JUCE#1810 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
petercorke/robotics-toolbox-python#952 ·
Maintainers usually reply within 1 day
-
NatronRenderer: a Python error in the script (-t / project script) doesn't change the exit statusOpenfunc:engine type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
NatronGitHub/Natron#1276 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day