Launcher suite: two uninstall checks fail on main (RR settings after an in-game edit, RE9 mirror)

Offen
#219 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
28/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
cpp, python

Rechercherichtung

Run tests/run_launcher_tests.py to reproduce test_rr and test_re9, then read how repair records WrongGPU\wronggpu.ini: the move from copy 0 to copy 1 <sha> is what makes the final uninstall treat the file as another setup's. For test_re9, trace where _storage_\dxgi.dll is meant to be removed during update and uninstall. Also check main()'s synth_f argument (passed only to rr) and clean/linux/run_wine_tests.py, which builds only unit tests. Done means both checks pass on main, or are shown stale and updated.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Two checks of tests/run_launcher_tests.py fail on main (9ef4da7). Found while merging main into the native Linux launcher branch; both reproduce the same way with main's own launcher (MinGW WRONGGPU_TESTING build, -DWRONGGPU_PRESET_K=OFF) under Wine (GE-Proton 11-11). Not run on Windows, so it is possible the checks rather than the code are out of date.

1. test_rr: "uninstall: exit 0, the RR game's folder as before except the two RR settings files the plugin rewrote..."

After the suite edits WrongGPU\wronggpu.ini as the plugin would (rr_mode = fast, rr_overlay=1), the next repair records that file as the player's: its record line goes from copy 0 - <inst> to copy 1 <sha of the edited file> <inst> ("Backed up and replaced"). The final uninstall then says it is "partly" done (WrongGPU\wronggpu.ini is now another setup's OptiScaler) and leaves WrongGPU-originals\<stamp>\WrongGPU\wronggpu.ini behind, which the check does not expect.

2. test_re9: "uninstall after the update: everything of WrongGPU's gone from the folder and the mirror; the player's mirrored file stays"

_storage_\dxgi.dll (sha256 6c66d3d8...) is left after the update and uninstall.

Also

  • The WrongGPU target no longer builds with llvm-mingw 20261104: WICBitmapInterpolationModeHighQualityCubic, D2D1_GAUSSIANBLUR_OPTIMIZATION_QUALITY, UIA_ScrollPatternNoScroll and the __uuidof of two UI Automation interfaces are missing from its headers. clean/linux/run_wine_tests.py builds only the unit tests, so it does not catch this. MinGW is for testing only, so this may not matter to you.
  • --only re9 fails at the call: main() passes synth_f only to rr.
Vorherrschende Sprache
C++
Sterne
12
Forks
2
Ø Merge
3 Std. 10 Min.
Gemergte PRs (30 T.)
171

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus phantoslayer21/wronggpu

Alle Issues in phantoslayer21/wronggpu

Ähnliche Issues

Weitere Issues zu C++

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.