Launcher suite: two uninstall checks fail on main (RR settings after an in-game edit, RE9 mirror)

未關閉
#219 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
28/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
cpp, python

研究方向

Run tests/run_launcher_tests.py to reproduce test_rr and test_re9, then read how repair records WrongGPU\wronggpu.ini: the move from copy 0 to copy 1 <sha> is what makes the final uninstall treat the file as another setup's. For test_re9, trace where _storage_\dxgi.dll is meant to be removed during update and uninstall. Also check main()'s synth_f argument (passed only to rr) and clean/linux/run_wine_tests.py, which builds only unit tests. Done means both checks pass on main, or are shown stale and updated.

由索引模型根據 Issue 內容生成。

描述

Two checks of tests/run_launcher_tests.py fail on main (9ef4da7). Found while merging main into the native Linux launcher branch; both reproduce the same way with main's own launcher (MinGW WRONGGPU_TESTING build, -DWRONGGPU_PRESET_K=OFF) under Wine (GE-Proton 11-11). Not run on Windows, so it is possible the checks rather than the code are out of date.

1. test_rr: "uninstall: exit 0, the RR game's folder as before except the two RR settings files the plugin rewrote..."

After the suite edits WrongGPU\wronggpu.ini as the plugin would (rr_mode = fast, rr_overlay=1), the next repair records that file as the player's: its record line goes from copy 0 - <inst> to copy 1 <sha of the edited file> <inst> ("Backed up and replaced"). The final uninstall then says it is "partly" done (WrongGPU\wronggpu.ini is now another setup's OptiScaler) and leaves WrongGPU-originals\<stamp>\WrongGPU\wronggpu.ini behind, which the check does not expect.

2. test_re9: "uninstall after the update: everything of WrongGPU's gone from the folder and the mirror; the player's mirrored file stays"

_storage_\dxgi.dll (sha256 6c66d3d8...) is left after the update and uninstall.

Also

  • The WrongGPU target no longer builds with llvm-mingw 20261104: WICBitmapInterpolationModeHighQualityCubic, D2D1_GAUSSIANBLUR_OPTIMIZATION_QUALITY, UIA_ScrollPatternNoScroll and the __uuidof of two UI Automation interfaces are missing from its headers. clean/linux/run_wine_tests.py builds only the unit tests, so it does not catch this. MinGW is for testing only, so this may not matter to you.
  • --only re9 fails at the call: main() passes synth_f only to rr.
主要語言
C++
星號
12
分支
2
平均合併
3 小時 10 分鐘
30 天內合併 PR
171

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

phantoslayer21/wronggpu 的其他 Issue

查看 phantoslayer21/wronggpu 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。