Guild storage: gold deposit refused (player report BUG-091)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 22/100
Research direction
Start in applyGuildStorageMove in apps/server/internal/game/action/npcguildstorage.go and list the four refusal checks: warehouse session, manager range, single holder, guild level 2. Run go test -run TestGuildWarehouseOpensAtLevelTwoForOneMember in npcguild_test.go to see the passing baseline, then reproduce the reporter's deposit on a local stack. Done when the failing rule is identified and either fixed or answered with the native v1.150 rule and message.
Written by the indexing model from the issue text.
Description
Player report from Discord (2026-11-13, BUG-091): gold cannot be deposited into the guild storage. No steps, build or screenshot were given.
What the server does today (apps/server/internal/game/action/npcguildstorage.go, applyGuildStorageMove): a guild gold deposit is accepted only when all of these hold:
- the member opened the guild warehouse at the guild manager, and that opening is still the character's warehouse session (another warehouse, a shop, an exchange, a stall or death ends it);
- the manager is still in range;
- the member holds the guild's warehouse (one holder at a time);
- the guild is level 2 or higher, so it has a storage room.
Each failure answers the same generic refusal (ErrCodeInvalidRequest), so the player cannot tell which rule refused. TestGuildWarehouseOpensAtLevelTwoForOneMember (npcguild_test.go) covers a level-2 guild's deposit and the closed-room refusal of a withdraw; it passes at 8d873f737 (go test -run, 0.46 s).
To find out
- Which of the rules above the reporter hit: guild level, whether the warehouse window opened, and whether another member held it.
- What the native v1.150 client shows for each refusal. If the native server answers distinct error codes, use them instead of the generic one.
Done when the reporter's case reproduces on a local stack and is either fixed, or answered with the native rule and its native message.
- Dominant language
- Go
- Stars
- 97
- Forks
- 61
- Avg merge
- 4h 14m
- Merged PRs (30d)
- 913
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from opensro-dev/opensro
-
area: client enhancement priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
opensro-dev/opensro#3681 ·
Maintainers usually reply within 1 day
-
area: client bug priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
opensro-dev/opensro#3228 · 1 comment ·
Maintainers usually reply within 1 day
-
Format one minified client file with dprint (ongoing: one file per PR)Possibly taken A pull request linked to this issue is open or already merged. Openarea: client enhancement good first issue priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
opensro-dev/opensro#1 · 1 comment ·
Maintainers usually reply within 1 day
-
area: server bug priority: medium
Difficulty 3/5 Half a day Newbie friendliness 55/100
opensro-dev/opensro#3687 ·
Maintainers usually reply within 1 day
-
area: ops bug priority: high
Difficulty 4/5 3-5 days Newbie friendliness 32/100
opensro-dev/opensro#3685 ·
Maintainers usually reply within 1 day
All issues in opensro-dev/opensro
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
unbound-force/gaze#353 ·
Maintainers usually reply within 1 day
-
bug cross-seed ready-for-human
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
OneBusAway/maglev#2102 ·
Maintainers usually reply within 2 days
-
affects-8.5 component/session severity/moderate sig/transaction type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Waiting start: the fixed 503 body says another instance holds the lease when that may not be soOpen
Difficulty 1/5 Under an hour Newbie friendliness 70/100
Judgment-Pack/judgment-pack-gateway#474 ·
Maintainers usually reply within 1 day