Guild storage: gold deposit refused (player report BUG-091)

Open
#3,568 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
22/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Active
Tech stack
go
Domain
backend, game-dev

Research direction

Start in applyGuildStorageMove in apps/server/internal/game/action/npcguildstorage.go and list the four refusal checks: warehouse session, manager range, single holder, guild level 2. Run go test -run TestGuildWarehouseOpensAtLevelTwoForOneMember in npcguild_test.go to see the passing baseline, then reproduce the reporter's deposit on a local stack. Done when the failing rule is identified and either fixed or answered with the native v1.150 rule and message.

Written by the indexing model from the issue text.

Description

area: server bug priority: medium

Player report from Discord (2026-11-13, BUG-091): gold cannot be deposited into the guild storage. No steps, build or screenshot were given.

What the server does today (apps/server/internal/game/action/npcguildstorage.go, applyGuildStorageMove): a guild gold deposit is accepted only when all of these hold:

  • the member opened the guild warehouse at the guild manager, and that opening is still the character's warehouse session (another warehouse, a shop, an exchange, a stall or death ends it);
  • the manager is still in range;
  • the member holds the guild's warehouse (one holder at a time);
  • the guild is level 2 or higher, so it has a storage room.

Each failure answers the same generic refusal (ErrCodeInvalidRequest), so the player cannot tell which rule refused. TestGuildWarehouseOpensAtLevelTwoForOneMember (npcguild_test.go) covers a level-2 guild's deposit and the closed-room refusal of a withdraw; it passes at 8d873f737 (go test -run, 0.46 s).

To find out

  • Which of the rules above the reporter hit: guild level, whether the warehouse window opened, and whether another member held it.
  • What the native v1.150 client shows for each refusal. If the native server answers distinct error codes, use them instead of the generic one.

Done when the reporter's case reproduces on a local stack and is either fixed, or answered with the native rule and its native message.

Dominant language
Go
Stars
97
Forks
61
Avg merge
4h 14m
Merged PRs (30d)
913

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from opensro-dev/opensro

All issues in opensro-dev/opensro

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.