Guild storage: gold deposit refused (player report BUG-091)

Ouverte
#3,568 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
22/100
Type d'issue
Bug
Clarté
À clarifier
Activité
Active
Stack technique
go
Domaine
backend, game-dev

Piste de recherche

Start in applyGuildStorageMove in apps/server/internal/game/action/npcguildstorage.go and list the four refusal checks: warehouse session, manager range, single holder, guild level 2. Run go test -run TestGuildWarehouseOpensAtLevelTwoForOneMember in npcguild_test.go to see the passing baseline, then reproduce the reporter's deposit on a local stack. Done when the failing rule is identified and either fixed or answered with the native v1.150 rule and message.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area: server bug priority: medium

Player report from Discord (2026-11-13, BUG-091): gold cannot be deposited into the guild storage. No steps, build or screenshot were given.

What the server does today (apps/server/internal/game/action/npcguildstorage.go, applyGuildStorageMove): a guild gold deposit is accepted only when all of these hold:

  • the member opened the guild warehouse at the guild manager, and that opening is still the character's warehouse session (another warehouse, a shop, an exchange, a stall or death ends it);
  • the manager is still in range;
  • the member holds the guild's warehouse (one holder at a time);
  • the guild is level 2 or higher, so it has a storage room.

Each failure answers the same generic refusal (ErrCodeInvalidRequest), so the player cannot tell which rule refused. TestGuildWarehouseOpensAtLevelTwoForOneMember (npcguild_test.go) covers a level-2 guild's deposit and the closed-room refusal of a withdraw; it passes at 8d873f737 (go test -run, 0.46 s).

To find out

  • Which of the rules above the reporter hit: guild level, whether the warehouse window opened, and whether another member held it.
  • What the native v1.150 client shows for each refusal. If the native server answers distinct error codes, use them instead of the generic one.

Done when the reporter's case reproduces on a local stack and is either fixed, or answered with the native rule and its native message.

Langage dominant
Go
Étoiles
97
Forks
61
Merge moyen
4 h 14 min
PR mergées (30 j)
913

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de opensro-dev/opensro

Toutes les issues de opensro-dev/opensro

Issues similaires

Plus d'issues Go

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.