client: hwir tooltip parameter prints on any nonzero value, as native
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
Research direction
The comparison lives in skill-tooltip-params.ts, in the switch case for 0x1e0 (hwir), which tests the value with > 0. Compare it with cases 0x070 and 0x1a0, which use !== 0, and change 0x1e0 to match. Add a test that a negative hwir parameter is printed. Done when that test passes and the existing tooltip tests still pass.
Written by the indexing model from the issue text.
Description
skill-tooltip-params.ts case 0x1e0 (hwir) tests > 0, while native 0x7faa99 is a jbe on the parameter: any nonzero value prints. Use !== 0 as cases 0x070 and 0x1a0 do, and add a test that a negative hwir parameter prints.
Harmless for shipped data (no negative hwir rows), but it diverges from the native rule.
Moved from Backlog #2628 (from the #2651 review).
- Dominant language
- Go
- Stars
- 97
- Forks
- 61
- Avg merge
- 4h 14m
- Merged PRs (30d)
- 913
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from opensro-dev/opensro
-
area: client enhancement priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
opensro-dev/opensro#3681 ·
Maintainers usually reply within 1 day
-
Format one minified client file with dprint (ongoing: one file per PR)Possibly taken A pull request linked to this issue is open or already merged. Openarea: client enhancement good first issue priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
opensro-dev/opensro#1 · 1 comment ·
Maintainers usually reply within 1 day
-
area: server bug priority: medium
Difficulty 3/5 Half a day Newbie friendliness 55/100
opensro-dev/opensro#3687 ·
Maintainers usually reply within 1 day
-
area: ops bug priority: high
Difficulty 4/5 3-5 days Newbie friendliness 32/100
opensro-dev/opensro#3685 ·
Maintainers usually reply within 1 day
-
area: client bug priority: high
Difficulty 4/5 3-5 days Newbie friendliness 35/100
opensro-dev/opensro#3684 ·
Maintainers usually reply within 1 day
All issues in opensro-dev/opensro
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
unbound-force/gaze#353 ·
Maintainers usually reply within 1 day
-
bug cross-seed ready-for-human
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
OneBusAway/maglev#2102 ·
Maintainers usually reply within 2 days
-
affects-8.5 component/session severity/moderate sig/transaction type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Waiting start: the fixed 503 body says another instance holds the lease when that may not be soOpen
Difficulty 1/5 Under an hour Newbie friendliness 70/100
Judgment-Pack/judgment-pack-gateway#474 ·
Maintainers usually reply within 1 day