client: hwir tooltip parameter prints on any nonzero value, as native

Open Beginner friendly
#3,228 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
typescript
Domain
frontend, game-dev

Research direction

The comparison lives in skill-tooltip-params.ts, in the switch case for 0x1e0 (hwir), which tests the value with > 0. Compare it with cases 0x070 and 0x1a0, which use !== 0, and change 0x1e0 to match. Add a test that a negative hwir parameter is printed. Done when that test passes and the existing tooltip tests still pass.

Written by the indexing model from the issue text.

Description

area: client bug priority: low

skill-tooltip-params.ts case 0x1e0 (hwir) tests > 0, while native 0x7faa99 is a jbe on the parameter: any nonzero value prints. Use !== 0 as cases 0x070 and 0x1a0 do, and add a test that a negative hwir parameter prints.

Harmless for shipped data (no negative hwir rows), but it diverges from the native rule.

Moved from Backlog #2628 (from the #2651 review).

Dominant language
Go
Stars
97
Forks
61
Avg merge
4h 14m
Merged PRs (30d)
913

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from opensro-dev/opensro

All issues in opensro-dev/opensro

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.