Guild storage: gold deposit refused (player report BUG-091)

Abierto
#3,568 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
22/100
Tipo de issue
Error
Claridad
Necesita aclaración
Estado de actividad
Activo
Stack tecnológico
go
Área
backend, game-dev

Línea de trabajo

Start in applyGuildStorageMove in apps/server/internal/game/action/npcguildstorage.go and list the four refusal checks: warehouse session, manager range, single holder, guild level 2. Run go test -run TestGuildWarehouseOpensAtLevelTwoForOneMember in npcguild_test.go to see the passing baseline, then reproduce the reporter's deposit on a local stack. Done when the failing rule is identified and either fixed or answered with the native v1.150 rule and message.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: server bug priority: medium

Player report from Discord (2026-11-13, BUG-091): gold cannot be deposited into the guild storage. No steps, build or screenshot were given.

What the server does today (apps/server/internal/game/action/npcguildstorage.go, applyGuildStorageMove): a guild gold deposit is accepted only when all of these hold:

  • the member opened the guild warehouse at the guild manager, and that opening is still the character's warehouse session (another warehouse, a shop, an exchange, a stall or death ends it);
  • the manager is still in range;
  • the member holds the guild's warehouse (one holder at a time);
  • the guild is level 2 or higher, so it has a storage room.

Each failure answers the same generic refusal (ErrCodeInvalidRequest), so the player cannot tell which rule refused. TestGuildWarehouseOpensAtLevelTwoForOneMember (npcguild_test.go) covers a level-2 guild's deposit and the closed-room refusal of a withdraw; it passes at 8d873f737 (go test -run, 0.46 s).

To find out

  • Which of the rules above the reporter hit: guild level, whether the warehouse window opened, and whether another member held it.
  • What the native v1.150 client shows for each refusal. If the native server answers distinct error codes, use them instead of the generic one.

Done when the reporter's case reproduces on a local stack and is either fixed, or answered with the native rule and its native message.

Lenguaje dominante
Go
Estrellas
97
Forks
61
Merge medio
4 h 14 min
PR fusionados (30 d)
913

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de opensro-dev/opensro

Todos los issues de opensro-dev/opensro

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.