Guild storage: gold deposit refused (player report BUG-091)

Aperta
#3,568 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
22/100
Tipo di issue
Bug
Chiarezza
Da chiarire
Stato di attività
Attiva
Stack tecnologico
go
Ambito
backend, game-dev

Direzione di ricerca

Start in applyGuildStorageMove in apps/server/internal/game/action/npcguildstorage.go and list the four refusal checks: warehouse session, manager range, single holder, guild level 2. Run go test -run TestGuildWarehouseOpensAtLevelTwoForOneMember in npcguild_test.go to see the passing baseline, then reproduce the reporter's deposit on a local stack. Done when the failing rule is identified and either fixed or answered with the native v1.150 rule and message.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: server bug priority: medium

Player report from Discord (2026-11-13, BUG-091): gold cannot be deposited into the guild storage. No steps, build or screenshot were given.

What the server does today (apps/server/internal/game/action/npcguildstorage.go, applyGuildStorageMove): a guild gold deposit is accepted only when all of these hold:

  • the member opened the guild warehouse at the guild manager, and that opening is still the character's warehouse session (another warehouse, a shop, an exchange, a stall or death ends it);
  • the manager is still in range;
  • the member holds the guild's warehouse (one holder at a time);
  • the guild is level 2 or higher, so it has a storage room.

Each failure answers the same generic refusal (ErrCodeInvalidRequest), so the player cannot tell which rule refused. TestGuildWarehouseOpensAtLevelTwoForOneMember (npcguild_test.go) covers a level-2 guild's deposit and the closed-room refusal of a withdraw; it passes at 8d873f737 (go test -run, 0.46 s).

To find out

  • Which of the rules above the reporter hit: guild level, whether the warehouse window opened, and whether another member held it.
  • What the native v1.150 client shows for each refusal. If the native server answers distinct error codes, use them instead of the generic one.

Done when the reporter's case reproduces on a local stack and is either fixed, or answered with the native rule and its native message.

Lingua principale
Go
Stelle
97
Fork
61
Merge medio
4h 14m
PR unite (30g)
913

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di opensro-dev/opensro

Tutte le issue di opensro-dev/opensro

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.