Check behaviour if PR requires review which is never given

Open
#1,617 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Active
Tech stack
git, github, python
Domain
ci-cd, devtools

Research direction

Start by reviewing the new overview screen and the existing GitHub merge workflow; the issue does not name specific files or tests. Check whether the bot can bypass a required review from a team that cannot provide reviews, and compare that with the proposed required status or check suite. Done means establishing whether either approach works and which option should be pursued.

Written by the indexing model from the issue text.

Description

mergebot

With the new overview screen, the github merge workflow might become a lot more prominent and hard to ignore, it looks like one possible option might be to require a PR and on that PR require a review by a team which can't hand out reviews (@odoo/robodoo, @odoo/no-one), but the 'bot still needs to be able to bypass that requirement in order to integrate PRs. Then again it's exempt so that should not be an issue...

The alternative is to bundle robodoo's merge state in a required status, maybe with a check suite in order to make all the stuff more visible from above the fold on the overview layout since that moves the "state of the PR" first comment to the bottom. This would consume more tokens, and might require a few safety squints, but with moving most of the git ops to, well, git, the API use has dropped considerably: over the last 50 days, the highest X-RateLimit-Used has gotten is 656 / 5000...

Dominant language
Python
Stars
166
Forks
160
Avg merge
2d 14h
Merged PRs (30d)
32

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from odoo/runbot

All issues in odoo/runbot

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.