Link from Github to Runbot

Open
#1,584 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
github, python

Research direction

Start from the robodoo code that posts the mergebot checklist on pull requests, since the proposition is to add a similar separate message containing the Runbot bundle URL. Trace how the bundle name is derived from the PR branch or mergebot label, then reuse Runbot's existing branch-name-to-bundle resolution and build the /runbot/bundle/... link. Done means a new PR comment links to the correct bundle; the open questions about extra notifications and dynamic Runbot data still need a maintainer decision.

Written by the indexing model from the issue text.

Description

Context

The workflow of an Odoo change goes code -> push -> create PR -> follow-up merge-ability. On the golden path, the developer doesn't look at what runbot and mergebot are doing.

But this workflow has dead-ends for specific situation. The dead-end means the developer has to manually switch into Runbot.

  • Executing on special task types that requires custom bundle configuration on Runbot.
    • => Stuck after push
  • New colleagues (but externals can follow along too) are encouraged to click around and explore Runbot. They are instructed to create a PR to explore with a familiar context;
    • => Stuck after PR creation

Ideally the git server should reply with the Runbot bundle url, similar to how Github provides a link to directly PR against the upstream repository. Can not happen because we have no control over the git server response.

Stuck after PR creation can be solved by posting a link to the Runbot bundle on the PR, similar to how robodoo posts the mergebot checklist.

Proposition

Have robodoo post a link to the runbot bundle (the bundle which contains the PR and development branch) as a separate message on the PR.

Open questions

  • Do we want to create a second message and trigger extra notifications?
  • Do we want to show some dynamic data from Runbot, similar to the mergebot checklist image?

Other info

Runbot can already resolve bundles by branch-name, eg saas-19.4-16.0-race_941553-bepro-583517-fw (mergebot label: odoo-dev:saas-19.4-16.0-race_941553-bepro-583517-fw) => https://runbot.odoo.com/runbot/bundle/saas-19-4-16-0-race-941553-bepro-583517-fw-530504

Dominant language
Python
Stars
166
Forks
160
Avg merge
2d 14h
Merged PRs (30d)
32

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from odoo/runbot

All issues in odoo/runbot

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.