Sidecar `put_file_complete` retry should be made more sophisticated

Open Beginner friendly
#1,653 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
backend

Research direction

Start in transformer_sidecar/src/transformer_sidecar/servicex_adapter.py at the put_file_complete method linked in the issue, then compare its retry behavior with other retry logic in the project. Change the fixed retry delay to exponential backoff so short term app overloads or restarts are handled. Done when retries use increasing delays and the relevant tests or checks pass.

Written by the indexing model from the issue text.

Description

The sidecar put_file_complete method should really be altered to use exponential backoff instead of using a fixed retry time, bringing it closer to other places we do retry. This will help paper over potential short-term overloading/restarting of the app.

https://github.com/ssl-hep/ServiceX/blob/174c1cd7f8961e6be634742155f0b8e9b65df094/transformer_sidecar/src/transformer_sidecar/servicex_adapter.py#L108

Dominant language
Python
Stars
21
Forks
26
Avg merge
3d 23h
Merged PRs (30d)
26

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ssl-hep/ServiceX

All issues in ssl-hep/ServiceX

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.