API feedback collector
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 58/100
Research direction
The API changes described are under trigger serialization and build serialization; start by locating those serializers and reading the API implementation merged in #1598. Reorder trigger_purpose beside trigger in trigger output and group the build trigger fields under a trigger key. Done when both response shapes match the examples; the issue names no tests to run.
Written by the indexing model from the issue text.
Description
This is feedback on the Runbot API that got merged in #1598.
Questionable behavior
- Under trigger serialization (API: batch > slot > trigger), the purpose is at the end of the object. when manually looking at the output it's nice to have key 'trigger_purpose' close to its name.
{ trigger: 'xx', 'trigger_purpose': 'xx', manual: false, .. } - Under build serialization (API: build), the trigger data is split over multiple keys. for clearer responses and closer matching the runbot model move these properties under a single 'trigger' key.
{ children: [], trigger: { trigger: 'xx', trigger_purpose: 'xx' }, .. }
Feature requests
- Under bundle serialization (API: bundle), return external links (if any). this mimics behavior of the current runbot frontend where you can click through to the branch commit/github PR.
Positive feedback
- The logs array (API: batch > slot > trigger > build, build) is a good addition. People were parsing the log txt-files themselves before.
This statement says nothing about the structure of the log object.
- Dominant language
- Python
- Stars
- 166
- Forks
- 160
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 32
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from odoo/runbot
-
mergebot
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
mergebot
Difficulty 3/5 1-2 days Newbie friendliness 58/100
Maintainers usually reply within 1 day
-
mergebot
Difficulty 5/5 Over a week Newbie friendliness 35/100
odoo/runbot#1617 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
Maintainers usually reply within 1 day
-
mergebot
Difficulty 4/5 3-5 days Newbie friendliness 48/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 61/100
scverse/infercnvpy#238 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
skrub-data/skrub#2442 ·
Maintainers usually reply within 1 day
-
due_at is one hour late on the autumn DST change day (real-time delta added to a zoneinfo datetime)Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
open-feature/python-sdk-contrib#482 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 94/100
warlock20/StartWithA#443 ·
Maintainers usually reply within 1 day