Delete source branches if github app

Open
#1,620 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
58/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
github, python
Domain
devops

Research direction

Start by tracing the post-merge branch deletion flow and how it selects credentials for forward ports; the issue does not name specific files or tests. Check how the GitHub App credentials are used for both repositories, then verify that branch deletion is attempted after merges with and without forward ports and that failures are handled appropriately.

Written by the indexing model from the issue text.

Description

mergebot

Currently the post-merge branch deletion requires forward port to be enabled, because the fp token is the only one which has write access to the fp repository[^1].

With the switch to apps, the app is the one with access, to both sides of a forward port. Thus it can always try to delete branches.

[^1]: though since we don't use the API for deletion maybe we could try deleting with the regular token anyway?

Dominant language
Python
Stars
166
Forks
160
Avg merge
2d 14h
Merged PRs (30d)
32

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from odoo/runbot

All issues in odoo/runbot

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.