Delete source branches if github app
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 58/100
Research direction
Start by tracing the post-merge branch deletion flow and how it selects credentials for forward ports; the issue does not name specific files or tests. Check how the GitHub App credentials are used for both repositories, then verify that branch deletion is attempted after merges with and without forward ports and that failures are handled appropriately.
Written by the indexing model from the issue text.
Description
Currently the post-merge branch deletion requires forward port to be enabled, because the fp token is the only one which has write access to the fp repository[^1].
With the switch to apps, the app is the one with access, to both sides of a forward port. Thus it can always try to delete branches.
[^1]: though since we don't use the API for deletion maybe we could try deleting with the regular token anyway?
- Dominant language
- Python
- Stars
- 166
- Forks
- 160
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 32
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from odoo/runbot
-
mergebot
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
mergebot
Difficulty 5/5 Over a week Newbie friendliness 35/100
odoo/runbot#1617 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
Maintainers usually reply within 1 day
-
mergebot
Difficulty 4/5 3-5 days Newbie friendliness 48/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 61/100
scverse/infercnvpy#238 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
skrub-data/skrub#2442 ·
Maintainers usually reply within 1 day
-
due_at is one hour late on the autumn DST change day (real-time delta added to a zoneinfo datetime)Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
open-feature/python-sdk-contrib#482 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 94/100
warlock20/StartWithA#443 ·
Maintainers usually reply within 1 day