Add `dataset_id` prefix to tables in Visium HD
まだ誰も着手していません。
評価
調査の方向性
まず、Tables エントリを作成する Visium HD reader のコードを見つけ、issue に示されている Images および Shapes とその命名を比較します。Visium HD の Tables 名に dataset_id プレフィックスが含まれ、他の要素と一致し、SpatialData オブジェクトを連結したときに重複する Table 名が発生しなければ完了です。
索引モデルが issue の本文から書いたものです。
説明
Thanks for the clarification. That makes sense.
One small detail. Should not the elements in
Tablesbe renamed as well? Right now they are not (see above). If I try to concatenate two visium_hdSpatialDataobjects I get a warning about identical names and they are given unique names which are not ideal because do not follow the original patterns, making it harder to know which ones came from where.>> sdata1 SpatialData object ├── Images │ ├── 'HM_hires_image': DataArray[cyx] (3, 5057, 6000) │ └── 'HM_lowres_image': DataArray[cyx] (3, 506, 600) ├── Shapes │ ├── 'HM_square_002um': GeoDataFrame shape: (2942291, 1) (2D shapes) │ ├── 'HM_square_008um': GeoDataFrame shape: (187571, 1) (2D shapes) │ └── 'HM_square_016um': GeoDataFrame shape: (48206, 1) (2D shapes) └── Tables ├── 'square_002um': AnnData (2942291, 18085) ├── 'square_008um': AnnData (187571, 18085) └── 'square_016um': AnnData (48206, 18085) with coordinate systems: ▸ 'downscaled_hires', with elements: HM_hires_image (Images), HM_square_002um (Shapes), HM_square_008um (Shapes), HM_square_016um (Shapes) ▸ 'downscaled_lowres', with elements: HM_lowres_image (Images), HM_square_002um (Shapes), HM_square_008um (Shapes), HM_square_016um (Shapes) ▸ 'global', with elements: HM_hires_image (Images), HM_lowres_image (Images), HM_square_002um (Shapes), HM_square_008um (Shapes), HM_square_016um (Shapes) >> sdata2 SpatialData object ├── Images │ ├── 'RS_hires_image': DataArray[cyx] (3, 6000, 5163) │ └── 'RS_lowres_image': DataArray[cyx] (3, 600, 517) ├── Shapes │ ├── 'RS_square_002um': GeoDataFrame shape: (2493008, 1) (2D shapes) │ ├── 'RS_square_008um': GeoDataFrame shape: (160049, 1) (2D shapes) │ └── 'RS_square_016um': GeoDataFrame shape: (41439, 1) (2D shapes) └── Tables ├── 'square_002um': AnnData (2493008, 18085) ├── 'square_008um': AnnData (160049, 18085) └── 'square_016um': AnnData (41439, 18085) with coordinate systems: ▸ 'downscaled_hires', with elements: RS_hires_image (Images), RS_square_002um (Shapes), RS_square_008um (Shapes), RS_square_016um (Shapes) ▸ 'downscaled_lowres', with elements: RS_lowres_image (Images), RS_square_002um (Shapes), RS_square_008um (Shapes), RS_square_016um (Shapes) ▸ 'global', with elements: RS_hires_image (Images), RS_lowres_image (Images), RS_square_002um (Shapes), RS_square_008um (Shapes), RS_square_016um (Shapes) >> sd.concatenate([sdata1, sdata2]) <stdin>:1: UserWarning: Duplicate table names found. Tables will be added with integer suffix. Set `concatenate_tables` to `True` if concatenation is wished for instead. SpatialData object ├── Images │ ├── 'HM_hires_image': DataArray[cyx] (3, 5057, 6000) │ ├── 'HM_lowres_image': DataArray[cyx] (3, 506, 600) │ ├── 'RS_hires_image': DataArray[cyx] (3, 6000, 5163) │ └── 'RS_lowres_image': DataArray[cyx] (3, 600, 517) ├── Shapes │ ├── 'HM_square_002um': GeoDataFrame shape: (2942291, 1) (2D shapes) │ ├── 'HM_square_008um': GeoDataFrame shape: (187571, 1) (2D shapes) │ ├── 'HM_square_016um': GeoDataFrame shape: (48206, 1) (2D shapes) │ ├── 'RS_square_002um': GeoDataFrame shape: (2493008, 1) (2D shapes) │ ├── 'RS_square_008um': GeoDataFrame shape: (160049, 1) (2D shapes) │ └── 'RS_square_016um': GeoDataFrame shape: (41439, 1) (2D shapes) └── Tables ├── 'square_002um_0': AnnData (2942291, 18085) ├── 'square_002um_1': AnnData (2493008, 18085) ├── 'square_008um_0': AnnData (187571, 18085) ├── 'square_008um_1': AnnData (160049, 18085) ├── 'square_016um_0': AnnData (48206, 18085) └── 'square_016um_1': AnnData (41439, 18085) with coordinate systems: ▸ 'downscaled_hires', with elements: HM_hires_image (Images), RS_hires_image (Images), HM_square_002um (Shapes), HM_square_008um (Shapes), HM_square_016um (Shapes), RS_square_002um (Shapes), RS_square_008um (Shapes), RS_square_016um (Shapes) ▸ 'downscaled_lowres', with elements: HM_lowres_image (Images), RS_lowres_image (Images), HM_square_002um (Shapes), HM_square_008um (Shapes), HM_square_016um (Shapes), RS_square_002um (Shapes), RS_square_008um (Shapes), RS_square_016um (Shapes) ▸ 'global', with elements: HM_hires_image (Images), HM_lowres_image (Images), RS_hires_image (Images), RS_lowres_image (Images), HM_square_002um (Shapes), HM_square_008um (Shapes), HM_square_016um (Shapes), RS_square_002um (Shapes), RS_square_008um (Shapes), RS_square_016um (Shapes)
Originally posted by @ddiez in #212
- 主要言語
- Python
- スター
- 105
- フォーク
- 64
- PR マージ指標
- 30日以内にマージされた PR はありません
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
scverse/spatialdata-io のほかの issue
-
documentation
難易度 2/5 半日 初心者へのやさしさ 65/100
scverse/spatialdata-io#161 · コメント 13 件 ·
-
bug
難易度 3/5 1〜2日 初心者へのやさしさ 58/100
scverse/spatialdata-io#422 ·
-
難易度 4/5 3〜5日 初心者へのやさしさ 45/100
scverse/spatialdata-io#419 · コメント 1 件 ·
-
MCMICRO reader does not support new nf-core/mcmicro output formats対応中かも @adamjtaylor が 85 日前に担当しました。 オープン
難易度 5/5 1週間以上 初心者へのやさしさ 48/100
scverse/spatialdata-io#409 · リアクション 1 件 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 52/100
scverse/spatialdata-io#408 ·
scverse/spatialdata-io の issue をすべて見る
似ている issue
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
jbacalso24/mimry#291 ·
メンテナーはふだん 1 日以内に返信
-
good first issue
難易度 2/5 1時間未満 初心者へのやさしさ 82/100
eli-alvarado/us-watchlist-alerts#14 ·
メンテナーはふだん 1 日以内に返信
-
from-review-extraction python severity:nit
難易度 2/5 1〜3時間 初心者へのやさしさ 80/100
LearningCircuit/local-deep-research#7462 ·
メンテナーはふだん 2 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
cathrynlavery/diagram-design#441 ·
メンテナーはふだん 2 日以内に返信
-
[Cleanup] Include the public header in work_split.cpp対応中かも @blozano-tt が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
tenstorrent/tt-metal#60850 ·
メンテナーはふだん 1 日以内に返信