Show pending evaluation instead of premature project failure and zero scores (CMP drift)

オープン
#525 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@alexeygrigorev がすでに取り組んでいます。

2026年11月16日 から。

  • #527 @alexeygrigorev による — オープン

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
35/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
django, playwright, python
領域
backend, testing

調査の方向性

Start with courses/templates/projects/results.html and the referenced course and verification specs. Trace how the results page identifies submissions, PeerReview records, and persisted ProjectEvaluationScore evidence, then inspect the focused Django tests and applicable Playwright checks. Done means pending submissions show no outcome or scores while evaluated results, empty states, learner/cohort scoping, and existing feedback behavior remain correct; the issue also requires independent screenshot review and production verification.

索引モデルが issue の本文から書いたものです。

説明

bug courses frontend P1

Problem and provenance

courses/templates/projects/results.html displays Failed and default scores whenever the learner has a submission, even before evaluation exists. CMP 83242da hides outcomes and score sections until evaluation exists. This is a fourth focused port under intake 835873e9-5f63-4e5d-b0f9-0773e1d562b6; publish the audit amendment before implementation.

Authority

  • _docs/specs/04-courses-and-cohorts.md: preserve cohort-specific project reviews, scoring, results and statistics.
  • _docs/specs/07-security-privacy-operations.md: private learner data, no-store learner responses.
  • _docs/specs/10-verification-strategy.md; _docs/ci/change-selective-ci.md.

Scope

On canonical cohort project results pages, distinguish no submission, pending evaluation and evaluated submission. Adapt CMP to current website evaluation persistence: submitted PeerReview and/or persisted ProjectEvaluationScore are existing evidence; there is no submission.evaluated boolean. Preserve current system/fallback evaluation behavior. Do not infer that every learner was evaluated merely because project state is COMPLETED, or that every evaluation requires project completion.

Acceptance criteria

  • Submission without evaluation evidence shows a clear pending/no-evaluation-yet notice and does not display Passed/Failed, default total/component scores or a misleading criteria outcome.
  • A submitted peer evaluation or persisted system/fallback criterion evaluation permits the existing result representation; legitimate zero/failing evaluated scores remain visible as evaluated outcomes.
  • Anonymous sign-in and no-submission/volunteer-only empty states remain safe; results remain scoped to the current learner and cohort.
  • Current submission metadata/navigation remains usable; peer feedback and criteria vote calculations preserve existing evaluated behavior and no-review fallback handling.
  • Focused Django tests cover pending, peer-evaluated, system/fallback-evaluated, evaluated zero/failure, anonymous and no-submission cases; applicable Playwright checks pass. Independent tester captures and inspects desktop/mobile pending/evaluated screenshots.
  • Exact base/head selective verification plan, independent tester and PM acceptance, required checks green on PR exact head, merge and candidate live verification at prod.datatalks.club.

Boundaries

No grading algorithm/state-machine changes, data writes from result GETs, new evaluation subsystem or email changes. CMP stays read-only; courses.datatalks.club, current datatalks.club, join.datatalks.club, signup emails and Slack settings remain unchanged. No real-user mail. No dependency on other drift ports.

主要言語
Python
スター
0
フォーク
0
平均マージ
37分
マージ済み PR(30日)
36

環境構築

  • Dockerfile または Docker Compose ファイルあり
  • プルリクエストのテンプレートなし
  • コントリビューションガイドなし

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

DataTalksClub/website のほかの issue

DataTalksClub/website の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。