Show pending evaluation instead of premature project failure and zero scores (CMP drift)

Abierto
#525 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@alexeygrigorev ya está trabajando en esto.

Desde el 16/11/2026.

  • #527 de @alexeygrigorev — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
django, playwright, python
Área
backend, testing

Línea de trabajo

Start with courses/templates/projects/results.html and the referenced course and verification specs. Trace how the results page identifies submissions, PeerReview records, and persisted ProjectEvaluationScore evidence, then inspect the focused Django tests and applicable Playwright checks. Done means pending submissions show no outcome or scores while evaluated results, empty states, learner/cohort scoping, and existing feedback behavior remain correct; the issue also requires independent screenshot review and production verification.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug courses frontend P1

Problem and provenance

courses/templates/projects/results.html displays Failed and default scores whenever the learner has a submission, even before evaluation exists. CMP 83242da hides outcomes and score sections until evaluation exists. This is a fourth focused port under intake 835873e9-5f63-4e5d-b0f9-0773e1d562b6; publish the audit amendment before implementation.

Authority

  • _docs/specs/04-courses-and-cohorts.md: preserve cohort-specific project reviews, scoring, results and statistics.
  • _docs/specs/07-security-privacy-operations.md: private learner data, no-store learner responses.
  • _docs/specs/10-verification-strategy.md; _docs/ci/change-selective-ci.md.

Scope

On canonical cohort project results pages, distinguish no submission, pending evaluation and evaluated submission. Adapt CMP to current website evaluation persistence: submitted PeerReview and/or persisted ProjectEvaluationScore are existing evidence; there is no submission.evaluated boolean. Preserve current system/fallback evaluation behavior. Do not infer that every learner was evaluated merely because project state is COMPLETED, or that every evaluation requires project completion.

Acceptance criteria

  • Submission without evaluation evidence shows a clear pending/no-evaluation-yet notice and does not display Passed/Failed, default total/component scores or a misleading criteria outcome.
  • A submitted peer evaluation or persisted system/fallback criterion evaluation permits the existing result representation; legitimate zero/failing evaluated scores remain visible as evaluated outcomes.
  • Anonymous sign-in and no-submission/volunteer-only empty states remain safe; results remain scoped to the current learner and cohort.
  • Current submission metadata/navigation remains usable; peer feedback and criteria vote calculations preserve existing evaluated behavior and no-review fallback handling.
  • Focused Django tests cover pending, peer-evaluated, system/fallback-evaluated, evaluated zero/failure, anonymous and no-submission cases; applicable Playwright checks pass. Independent tester captures and inspects desktop/mobile pending/evaluated screenshots.
  • Exact base/head selective verification plan, independent tester and PM acceptance, required checks green on PR exact head, merge and candidate live verification at prod.datatalks.club.

Boundaries

No grading algorithm/state-machine changes, data writes from result GETs, new evaluation subsystem or email changes. CMP stays read-only; courses.datatalks.club, current datatalks.club, join.datatalks.club, signup emails and Slack settings remain unchanged. No real-user mail. No dependency on other drift ports.

Lenguaje dominante
Python
Estrellas
0
Forks
0
Merge medio
37 min
PR fusionados (30 d)
36

Preparar el entorno

  • Incluye un Dockerfile o un archivo de Docker Compose
  • Sin plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de DataTalksClub/website

Todos los issues de DataTalksClub/website

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.