Bound leaderboard staleness with database-owned cohort cache versions (CMP drift)

オープン
#524 コメント 3 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
35/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
python

調査の方向性

Read the four authority documents named in the issue, then trace the Cohort model, leaderboard recalculation, HTML row cache, and public export/YAML cache paths. Start by locating their existing tests and migration checks; use synthetic cohorts and learners with separate or stale cache instances to verify durable version reads, atomic rollback, visibility invalidation, and the 60-second configurable TTL. Done means the listed regression and migration checks pass while routes, payloads, privacy behavior, and dashboard behavior remain intact.

索引モデルが issue の本文から書いたものです。

説明

bug courses P1

Problem and provenance

Leaderboard invalidation currently increments a process-local cache key. Other Gunicorn processes retain HTML rows for an hour and API output for 24 hours, including a learner who changes leaderboard visibility. CMP dae6e36 bounds TTL and 036ace2 moves the version to the database. Intake 835873e9-5f63-4e5d-b0f9-0773e1d562b6 authorizes small PRs and candidate-only delivery.

Authority

  • _docs/specs/04-courses-and-cohorts.md: cohort-owned leaderboard/visibility preferences; assessment state remains cohort-specific.
  • _docs/specs/07-security-privacy-operations.md: database-owned protected learner state and cache isolation.
  • _docs/architecture/database-only-content.md.
  • _docs/specs/10-verification-strategy.md; _docs/ci/change-selective-ci.md.

Scope

Adapt CMP's database version to the current Cohort model, never reintroduce the historical Course-as-edition model. Add the minimal migration and atomic F increment shared by leaderboard recalculation and visibility invalidation. Both HTML row cache and public leaderboard export/YAML keys read the durable version. Bound data caches to a configurable 60-second default. Keep existing payload shapes, routes, pagination and privacy semantics. Website dashboard builds directly from the database; do not introduce CMP dashboard cache or change edge/browser caching.

Acceptance criteria

  • Existing cohorts migrate with a valid initial leaderboard version; migration drift check and forward/reverse migration coverage pass.
  • HTML and JSON/YAML leaderboard readers key cached data by the cohort's current database version, independently of process-local cache version entries.
  • Recalculation commits totals and a monotonic atomic version advance together; failure rolls both back. Concurrent advances do not lose increments.
  • Changing display_on_leaderboard invalidates both row and export caches through the durable version; tests simulate separate/stale worker-local caches and prove hidden learners disappear on the next fresh read.
  • Data cache TTL defaults to 60 seconds and respects supported configuration; no 1-hour/24-hour internal defaults remain on these leaderboard paths.
  • Cohort isolation, pagination, existing response payloads, learner visibility and private response policies pass focused regression tests. Dashboard behavior is preserved.
  • Exact base/head verification plan, independent tester and PM acceptance, required checks green on PR exact head, merge and candidate live verification at prod.datatalks.club.

Boundaries and verification

No production data export or real-user mail. CMP stays read-only; courses.datatalks.club, current datatalks.club, join.datatalks.club, signup emails and Slack settings unchanged. Test synthetic cohorts/learners and fresh/stale model instances plus separate cache aliases/cleared local caches as appropriate. Internal cache-only work has no intended render change; computed plan determines Playwright and screenshot disposition. No dependency on the CSRF or review-copy ports.

主要言語
Python
スター
0
フォーク
0
平均マージ
37分
マージ済み PR(30日)
36

環境構築

  • Dockerfile または Docker Compose ファイルあり
  • プルリクエストのテンプレートなし
  • コントリビューションガイドなし

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

DataTalksClub/website のほかの issue

DataTalksClub/website の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。