Show pending evaluation instead of premature project failure and zero scores (CMP drift)

未关闭
#525 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@alexeygrigorev 已经在做这个了。

开始于 2026年11月16日。

  • #527 来自 @alexeygrigorev —— 未关闭

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
django, playwright, python
领域
backend, testing

调研方向

Start with courses/templates/projects/results.html and the referenced course and verification specs. Trace how the results page identifies submissions, PeerReview records, and persisted ProjectEvaluationScore evidence, then inspect the focused Django tests and applicable Playwright checks. Done means pending submissions show no outcome or scores while evaluated results, empty states, learner/cohort scoping, and existing feedback behavior remain correct; the issue also requires independent screenshot review and production verification.

由索引模型根据 Issue 内容生成。

描述

bug courses frontend P1

Problem and provenance

courses/templates/projects/results.html displays Failed and default scores whenever the learner has a submission, even before evaluation exists. CMP 83242da hides outcomes and score sections until evaluation exists. This is a fourth focused port under intake 835873e9-5f63-4e5d-b0f9-0773e1d562b6; publish the audit amendment before implementation.

Authority

  • _docs/specs/04-courses-and-cohorts.md: preserve cohort-specific project reviews, scoring, results and statistics.
  • _docs/specs/07-security-privacy-operations.md: private learner data, no-store learner responses.
  • _docs/specs/10-verification-strategy.md; _docs/ci/change-selective-ci.md.

Scope

On canonical cohort project results pages, distinguish no submission, pending evaluation and evaluated submission. Adapt CMP to current website evaluation persistence: submitted PeerReview and/or persisted ProjectEvaluationScore are existing evidence; there is no submission.evaluated boolean. Preserve current system/fallback evaluation behavior. Do not infer that every learner was evaluated merely because project state is COMPLETED, or that every evaluation requires project completion.

Acceptance criteria

  • Submission without evaluation evidence shows a clear pending/no-evaluation-yet notice and does not display Passed/Failed, default total/component scores or a misleading criteria outcome.
  • A submitted peer evaluation or persisted system/fallback criterion evaluation permits the existing result representation; legitimate zero/failing evaluated scores remain visible as evaluated outcomes.
  • Anonymous sign-in and no-submission/volunteer-only empty states remain safe; results remain scoped to the current learner and cohort.
  • Current submission metadata/navigation remains usable; peer feedback and criteria vote calculations preserve existing evaluated behavior and no-review fallback handling.
  • Focused Django tests cover pending, peer-evaluated, system/fallback-evaluated, evaluated zero/failure, anonymous and no-submission cases; applicable Playwright checks pass. Independent tester captures and inspects desktop/mobile pending/evaluated screenshots.
  • Exact base/head selective verification plan, independent tester and PM acceptance, required checks green on PR exact head, merge and candidate live verification at prod.datatalks.club.

Boundaries

No grading algorithm/state-machine changes, data writes from result GETs, new evaluation subsystem or email changes. CMP stays read-only; courses.datatalks.club, current datatalks.club, join.datatalks.club, signup emails and Slack settings remain unchanged. No real-user mail. No dependency on other drift ports.

主要语言
Python
星标
0
派生
0
平均合并
37 分钟
30 天内合并 PR
36

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

DataTalksClub/website 的其他 Issue

查看 DataTalksClub/website 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。