Show pending evaluation instead of premature project failure and zero scores (CMP drift)

Aperta
#525 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@alexeygrigorev ci sta già lavorando.

Dal 16/11/2026.

  • #527 di @alexeygrigorev — aperta

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
django, playwright, python
Ambito
backend, testing

Direzione di ricerca

Start with courses/templates/projects/results.html and the referenced course and verification specs. Trace how the results page identifies submissions, PeerReview records, and persisted ProjectEvaluationScore evidence, then inspect the focused Django tests and applicable Playwright checks. Done means pending submissions show no outcome or scores while evaluated results, empty states, learner/cohort scoping, and existing feedback behavior remain correct; the issue also requires independent screenshot review and production verification.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug courses frontend P1

Problem and provenance

courses/templates/projects/results.html displays Failed and default scores whenever the learner has a submission, even before evaluation exists. CMP 83242da hides outcomes and score sections until evaluation exists. This is a fourth focused port under intake 835873e9-5f63-4e5d-b0f9-0773e1d562b6; publish the audit amendment before implementation.

Authority

  • _docs/specs/04-courses-and-cohorts.md: preserve cohort-specific project reviews, scoring, results and statistics.
  • _docs/specs/07-security-privacy-operations.md: private learner data, no-store learner responses.
  • _docs/specs/10-verification-strategy.md; _docs/ci/change-selective-ci.md.

Scope

On canonical cohort project results pages, distinguish no submission, pending evaluation and evaluated submission. Adapt CMP to current website evaluation persistence: submitted PeerReview and/or persisted ProjectEvaluationScore are existing evidence; there is no submission.evaluated boolean. Preserve current system/fallback evaluation behavior. Do not infer that every learner was evaluated merely because project state is COMPLETED, or that every evaluation requires project completion.

Acceptance criteria

  • Submission without evaluation evidence shows a clear pending/no-evaluation-yet notice and does not display Passed/Failed, default total/component scores or a misleading criteria outcome.
  • A submitted peer evaluation or persisted system/fallback criterion evaluation permits the existing result representation; legitimate zero/failing evaluated scores remain visible as evaluated outcomes.
  • Anonymous sign-in and no-submission/volunteer-only empty states remain safe; results remain scoped to the current learner and cohort.
  • Current submission metadata/navigation remains usable; peer feedback and criteria vote calculations preserve existing evaluated behavior and no-review fallback handling.
  • Focused Django tests cover pending, peer-evaluated, system/fallback-evaluated, evaluated zero/failure, anonymous and no-submission cases; applicable Playwright checks pass. Independent tester captures and inspects desktop/mobile pending/evaluated screenshots.
  • Exact base/head selective verification plan, independent tester and PM acceptance, required checks green on PR exact head, merge and candidate live verification at prod.datatalks.club.

Boundaries

No grading algorithm/state-machine changes, data writes from result GETs, new evaluation subsystem or email changes. CMP stays read-only; courses.datatalks.club, current datatalks.club, join.datatalks.club, signup emails and Slack settings remain unchanged. No real-user mail. No dependency on other drift ports.

Lingua principale
Python
Stelle
0
Fork
0
Merge medio
37m
PR unite (30g)
36

Preparare l'ambiente

  • Include un Dockerfile o un file Docker Compose
  • Nessun modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di DataTalksClub/website

Tutte le issue di DataTalksClub/website

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.