Define and preserve the failure state of kqueue event modifications

Aperta
  • Qualcosa non va?
#1,012 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
38/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
operating-systems

Direzione di ricerca

Start at std/sys/macos/event.wave:69 and review the event-modification flow that deletes existing filters before adding replacements. Coordinate with @LunaStev to agree on whether a failed modification preserves or invalidates the previous watch, since this issue does not approve the semantics. Done means injected delete/add failures verify the chosen watch/token state, callers cannot assume an active registration after loss, and Darwin/FreeBSD native tests confirm the behavior.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

discussion enhancement help wanted

Motivation

event_modify deletes existing filters before adding replacements. With successful deletion and an injected add EIO, the real macOS provider returns -5 after the old watch is gone. A Linux-hosted kevent-boundary fixture reproduces this at O0/O2. #783 already fixed ignored deletion errors; this is the later add-failure state.

Starting point: std/sys/macos/event.wave:69.

Validation

Audited canonical Wave 540728c2eb6cc12f5c69c3fb3fdb96e07ba059a4 (0.0.1-alpha-dev), whose tree matches the local checkout. Validation: Executed real macOS provider with controlled kevent boundary on Linux O0/O2; not native Darwin execution. Executed compiler probes use the matching checkout-built compiler and std on Linux amd64 (Rust 1.89.0 / LLVM 21.1.8). Source/header or mocked checks are not native execution on another OS.

Scope

Choose whether failed modification preserves the previous watch or explicitly invalidates it, and make the facade/callers honor that contract. Do not claim an atomic kernel transaction without evidence.

Related: #783. These links do not claim those broader or completed scopes are unfinished.

Design discussion required

This issue records a proposal or an unresolved contract; it is not approval to choose new semantics. Please mention @LunaStev to discuss the design before starting implementation.

Completion criteria

  • Inject delete/add partial failures and verify watch/token state.
  • Failed modification cannot leave callers assuming an active registration when it was lost.
  • Darwin/FreeBSD native regressions confirm the approved recovery behavior.
Lingua principale
Rust
Stelle
56
Fork
21
Merge medio
23h 20m
PR unite (30g)
45

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di wavefnd/Wave

Tutte le issue di wavefnd/Wave

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.