Preserve expression assembly result types when recording HIR conversions

Aperta
  • Qualcosa non va?
#1,081 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
compilers

Direzione di ricerca

Start at front/parser/src/verification/expression.rs, especially validate_expr_asm_block, which the issue identifies as returning Unknown. Trace how typed HIR records ordered conversions for initializers, returns, arithmetic, and casts, then check how LLVM consumes them. Done means supported typed scalar outputs preserve language conversions, unsupported contexts produce source diagnostics, and existing expression-asm regressions pass.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug help wanted

Problem

Expression-form assembly always validates to ExpressionType::Unknown even when its single output has a concrete scalar type. An enclosing initializer or return can therefore pass checking without the numeric conversion required by LLVM lowering. Ordinary arithmetic and explicit casts also see unknown rather than the typed result.

Starting point: validate_expr_asm_block, which returns Unknown after validating its operands.

Reproduction

Audited canonical master e1f8effd195b6339c3979b1e091e63c25f1da983 on Linux amd64 with checkout-built Wave 0.0.1-alpha-dev, matching std, Rust 1.89.0, Cargo jobs=2 and LLVM 21.1.8. The master SHA was rechecked before registration.

fun main() {
    var sink: i64 = 0;
    var result: bool = asm {
        "mov rax, 7"
        out("rax") sink
        clobber("nostack")
    };
}

target/debug/wavec --std-root "$PWD/std" check repro.wave
target/debug/wavec --std-root "$PWD/std" --error-format=json build repro.wave --emit=ir --out-dir .tmp/asm-type-repro

check exits 0. IR generation exits 1 with E9001:

ICE: numeric boundary conversion missing from HIR: variable 'result' initializer
compiler panic location: llvm/src/statement/variable.rs:83:13

Changing result to f64 produces the same failure. Returning the expression from a function declared -> i32 also passes check and fails with missing HIR conversion ret_cast. In a separate control, adding an integer to the expression or explicitly casting it is rejected because the result is unknown.

Scope

Determine the expression's established single-output result type in semantic analysis and preserve required ordered conversions in Typed HIR. LLVM must consume those facts rather than inventing conversions. Unsupported or incompatible contexts need a source diagnostic before code generation. Preserve the single-result output contract and one evaluation of asm and its operands.

Related: #512 is input-expression lowering and #679 is asm-initializer binding registration. Neither fixes the result-type/conversion boundary described here.

Completion criteria

  • Typed scalar asm results participate in supported initializers, returns, arithmetic and casts without Unknown leaking into validated HIR.
  • Supported bool/float/integer conversions follow existing language rules, widths and evaluation order.
  • Unsupported contexts fail with a source diagnostic rather than E9001.
  • Existing expression-asm input, output-count, binding and side-effect regressions continue to pass.
Lingua principale
Rust
Stelle
56
Fork
21
Merge medio
20h 49m
PR unite (30g)
45

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di wavefnd/Wave

Tutte le issue di wavefnd/Wave

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.