Preserve the previous build output when writing its Cargo receipt fails

Aperta
  • Qualcosa non va?
#1,079 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
56/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
build-system, cli

Direzione di ricerca

Start at the binary activation and receipt writing sequence in tools/src/build.rs around line 119, then trace the existing package backup restoration work in #1001 and the build identity checks. Reproduce the receipt destination conflict described in the issue and inspect the build-cargo tests for activation and rollback coverage. Done means a failed receipt write preserves both previous outputs or reports a retained recovery location, with successful builds activating a matching pair.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug build help wanted

Problem

The build-cargo helper replaces the requested output binary before writing its build.json receipt. If receipt serialization or activation fails, the helper returns an error after the previous output has already been lost. The two outputs can then describe different build generations.

Starting point: binary activation followed by receipt writing.

Reproduction

Audited canonical master e1f8effd195b6339c3979b1e091e63c25f1da983 on Linux amd64 with checkout-built Wave 0.0.1-alpha-dev, matching std, Rust 1.89.0, Cargo jobs=2 and LLVM 21.1.8. The master SHA was rechecked before registration.

Build the two tools from the audited checkout using the pinned toolchain and matching LLVM. The following Linux reproduction invokes real incremental Cargo, uses only disposable output paths, and makes the receipt destination a directory to force a deterministic activation error:

from pathlib import Path
import os
import subprocess
import tempfile

root = Path.cwd()
with tempfile.TemporaryDirectory(prefix="wave-build-receipt-") as temporary:
    output = Path(temporary) / "wavec"
    output.write_bytes(b"PREVIOUS-COMPILER")
    receipt = output.with_suffix(".build.json")
    receipt.mkdir()
    environment = os.environ.copy()
    environment["LLVM_SYS_211_PREFIX"] = "/usr/lib64/llvm21"
    result = subprocess.run([
        str(root / "target/debug/wave-tools"), "build-cargo",
        "--target", "x86_64-unknown-linux-gnu",
        "--binary", str(root / "target/debug/wavec"),
        "--output", str(output), "--",
        "cargo", "+1.89.0", "build", "--locked", "--jobs", "2",
        "-p", "wavec", "--bin", "wavec",
    ], env=environment, capture_output=True, text=True, timeout=300)
    print("exit:", result.returncode)
    print(result.stderr.strip())
    print("old bytes preserved:", output.read_bytes() == b"PREVIOUS-COMPILER")
    print("output header:", output.read_bytes()[:4])

Observed:

exit: 1
wave-tools: Is a directory (os error 21)
old bytes preserved: False
output header: b'\x7fELF'

The Cargo compiler build itself succeeded. Despite the helper's failed result, the previous sentinel was replaced by the new compiler. A directory at the receipt path is one reproducible failure injection, not the only possible receipt I/O failure.

Scope

Treat binary and receipt activation as one recoverable build-output operation. Prepare and validate both destinations before replacement; any later failure must preserve or restore the prior output set, retaining a recoverable backup if restoration itself fails. Keep Cargo compilation and Meson orchestration unchanged.

Related: #1001 covered package-set backup restoration, while #1070 delivered Rust tooling. Neither covers this build-cargo binary/receipt activation order.

Completion criteria

  • A receipt-write failure leaves the previous binary and receipt usable, or reports a retained recovery location if rollback cannot finish.
  • A successful invocation activates a matching binary/receipt pair.
  • Regressions cover a conflicting receipt destination and failures around activation and restoration.
  • Native platform replacement semantics and existing package/build identity checks remain intact.
Lingua principale
Rust
Stelle
56
Fork
21
Merge medio
20h 49m
PR unite (30g)
45

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di wavefnd/Wave

Tutte le issue di wavefnd/Wave

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.