Define and preserve the failure state of kqueue event modifications

Abierto
  • ¿Algo no está bien?
#1,012 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
38/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
rust
Área
operating-systems

Línea de trabajo

Start at std/sys/macos/event.wave:69 and review the event-modification flow that deletes existing filters before adding replacements. Coordinate with @LunaStev to agree on whether a failed modification preserves or invalidates the previous watch, since this issue does not approve the semantics. Done means injected delete/add failures verify the chosen watch/token state, callers cannot assume an active registration after loss, and Darwin/FreeBSD native tests confirm the behavior.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

discussion enhancement help wanted

Motivation

event_modify deletes existing filters before adding replacements. With successful deletion and an injected add EIO, the real macOS provider returns -5 after the old watch is gone. A Linux-hosted kevent-boundary fixture reproduces this at O0/O2. #783 already fixed ignored deletion errors; this is the later add-failure state.

Starting point: std/sys/macos/event.wave:69.

Validation

Audited canonical Wave 540728c2eb6cc12f5c69c3fb3fdb96e07ba059a4 (0.0.1-alpha-dev), whose tree matches the local checkout. Validation: Executed real macOS provider with controlled kevent boundary on Linux O0/O2; not native Darwin execution. Executed compiler probes use the matching checkout-built compiler and std on Linux amd64 (Rust 1.89.0 / LLVM 21.1.8). Source/header or mocked checks are not native execution on another OS.

Scope

Choose whether failed modification preserves the previous watch or explicitly invalidates it, and make the facade/callers honor that contract. Do not claim an atomic kernel transaction without evidence.

Related: #783. These links do not claim those broader or completed scopes are unfinished.

Design discussion required

This issue records a proposal or an unresolved contract; it is not approval to choose new semantics. Please mention @LunaStev to discuss the design before starting implementation.

Completion criteria

  • Inject delete/add partial failures and verify watch/token state.
  • Failed modification cannot leave callers assuming an active registration when it was lost.
  • Darwin/FreeBSD native regressions confirm the approved recovery behavior.
Lenguaje dominante
Rust
Estrellas
56
Forks
21
Merge medio
23 h 20 min
PR fusionados (30 d)
45

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de wavefnd/Wave

Todos los issues de wavefnd/Wave

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.