Define and preserve the failure state of kqueue event modifications

未关闭
#1,012 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
38/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
rust

调研方向

Start at std/sys/macos/event.wave:69 and review the event-modification flow that deletes existing filters before adding replacements. Coordinate with @LunaStev to agree on whether a failed modification preserves or invalidates the previous watch, since this issue does not approve the semantics. Done means injected delete/add failures verify the chosen watch/token state, callers cannot assume an active registration after loss, and Darwin/FreeBSD native tests confirm the behavior.

由索引模型根据 Issue 内容生成。

描述

discussion enhancement help wanted

Motivation

event_modify deletes existing filters before adding replacements. With successful deletion and an injected add EIO, the real macOS provider returns -5 after the old watch is gone. A Linux-hosted kevent-boundary fixture reproduces this at O0/O2. #783 already fixed ignored deletion errors; this is the later add-failure state.

Starting point: std/sys/macos/event.wave:69.

Validation

Audited canonical Wave 540728c2eb6cc12f5c69c3fb3fdb96e07ba059a4 (0.0.1-alpha-dev), whose tree matches the local checkout. Validation: Executed real macOS provider with controlled kevent boundary on Linux O0/O2; not native Darwin execution. Executed compiler probes use the matching checkout-built compiler and std on Linux amd64 (Rust 1.89.0 / LLVM 21.1.8). Source/header or mocked checks are not native execution on another OS.

Scope

Choose whether failed modification preserves the previous watch or explicitly invalidates it, and make the facade/callers honor that contract. Do not claim an atomic kernel transaction without evidence.

Related: #783. These links do not claim those broader or completed scopes are unfinished.

Design discussion required

This issue records a proposal or an unresolved contract; it is not approval to choose new semantics. Please mention @LunaStev to discuss the design before starting implementation.

Completion criteria

  • Inject delete/add partial failures and verify watch/token state.
  • Failed modification cannot leave callers assuming an active registration when it was lost.
  • Darwin/FreeBSD native regressions confirm the approved recovery behavior.
主要语言
Rust
星标
56
派生
21
平均合并
23 小时 20 分钟
30 天内合并 PR
45

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

wavefnd/Wave 的其他 Issue

查看 wavefnd/Wave 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。