C++ API snapshots: `ReactCommon` and `ReactAndroid` read the tvOS view headers, as `scripts/cxx-api/config.yml` does not exclude `*/platform/tvos/*`
I maintainer di solito rispondono entro 2 giorni
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Idoneità per principianti
- 72/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- bash, cpp, yaml
- Ambito
- build-system, mobile-dev
Direzione di ricerca
Inizia leggendo gli exclude_patterns di ReactCommon, ReactAndroid e ReactApple in scripts/cxx-api/config.yml, quindi confrontali con i percorsi delle piattaforme descritti nell’issue. Il riproduttore verifica le esclusioni e gli snapshot API sottoposti a commit; esegui bash repro.sh in un checkout per confermare il risultato attuale. Il lavoro è completato quando ReactCommon e ReactAndroid escludono gli header tvOS e gli snapshot interessati non includono più la classe tvOS, mentre le esclusioni per le altre piattaforme restano intatte.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Description
scripts/cxx-api/config.yml leaves each view platform folder out of the snapshots that are not for it: ReactCommon excludes */platform/cxx/*, windows, macos, ios and android (L27-L33), and ReactAndroid excludes cxx, windows, macos and ios (L58-L65). Neither names */platform/tvos/*, so both read ReactCommon/react/renderer/components/view/platform/tvos/:
- all four
ReactCommon*Cxx.apilistclass facebook::react::HostPlatformViewPropswithpublic bool focusable;, which only the tvOS header declares (L28); - each
ReactAndroid*Cxx.apimerges the tvOSHostPlatformViewPropsinto Android's. Onmainboth declarebool focusable{false};, so it does not show; https://github.com/react/react-native/pull/59048 makes Android'sstd::optional<bool> focusable{}, and its regeneratedReactAndroidDebugCxx.apilists bothpublic bool focusable;andpublic std::optional<bool> focusable;in the one class.
ReactApple does not exclude */platform/tvos/* either, and it does exclude */platform/cxx/*, the folder React-Fabric.podspec compiles for iOS (L168), so ReactAppleDebugCxx.api lists the tvOS class where iOS has using HostPlatformViewProps = BaseViewProps;.
Steps to reproduce
- Run
bash repro.shfrom the reproducer below. It sparse-clonesmain, matches each view platform'sHostPlatformViewProps.hagainst each snapshot'sexclude_patternsinscripts/cxx-api/config.yml(with the template's*/tests/*and*/samples/*), and prints theHostPlatformViewPropsclass of the committedReactCommon*Cxx.apiandReactAndroidDebugCxx.api.bash repro.sh <path to a react-native checkout>reads a checkout instead.
Expected: ReactCommon and ReactAndroid read nothing under platform/tvos, so no ReactCommon*Cxx.api lists a HostPlatformViewProps class and the ReactAndroid*Cxx.api class holds Android's members only; their other platform exclusions stay as they are.
Actual: both read platform/tvos/.../HostPlatformViewProps.h, and all four ReactCommon*Cxx.api list the tvOS class with public bool focusable; (log below).
React Native Version
main at bbfd391496 (nightly)
Affected Platforms
Other (please specify): the C++ API snapshots in scripts/cxx-api
Output of npx @react-native-community/cli info
Not applicable: this is the configuration of React Native's own C++ API snapshots. The reproducer's run:
react-native bbfd391 (2026-11-19), MINGW64_NT-10.0-26300 3.6.10-5a1665c8.x86_64, bash 5.3.15(2)-release
Stacktrace or Logs
react-native bbfd391 (2026-11-19), MINGW64_NT-10.0-26300 3.6.10-5a1665c8.x86_64, bash 5.3.15(2)-release
platform/android/.../HostPlatformViewProps.h:44: bool focusable{false};
platform/cxx/.../HostPlatformViewProps.h:15:using HostPlatformViewProps = BaseViewProps;
platform/tvos/.../HostPlatformViewProps.h:28: bool focusable{false};
config.yml ReactCommon exclude_patterns naming a platform folder: */platform/cxx/* */platform/windows/* */platform/macos/* */platform/ios/* */platform/android/*
ReactCommon reads HostPlatformViewProps.h from: platform/tvos
config.yml ReactAndroid exclude_patterns naming a platform folder: */platform/cxx/* */platform/windows/* */platform/macos/* */platform/ios/*
ReactAndroid reads HostPlatformViewProps.h from: platform/android platform/tvos
config.yml ReactApple exclude_patterns naming a platform folder: */platform/cxx/* */platform/windows/* */platform/macos/* */platform/android/*
ReactApple reads HostPlatformViewProps.h from: platform/tvos
ReactCommonDebugCxx.api:
676: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
679: public bool focusable;
ReactCommonFrameworksCxx.api:
1238: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
1241: public bool focusable;
ReactCommonNewarchCxx.api:
675: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
678: public bool focusable;
ReactCommonReleaseCxx.api:
675: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
678: public bool focusable;
ReactAndroidDebugCxx.api:
1329: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
1333: public bool focusable;
SUMMARY: snapshots whose exclude_patterns let them read platform/tvos/.../HostPlatformViewProps.h: ReactCommon ReactAndroid; committed ReactCommon snapshots with class facebook::react::HostPlatformViewProps: ReactCommonDebug ReactCommonFrameworks ReactCommonNewarch ReactCommonRelease
MANDATORY Reproducer
https://gist.github.com/YevheniiKotyrlo/d19e454d6ff5635c01ac24ce902e513e — bash repro.sh exits 1 while ReactCommon or ReactAndroid reads platform/tvos or a committed ReactCommon*Cxx.api lists class facebook::react::HostPlatformViewProps, and 0 once neither holds.
Screenshots and Videos
No response
- Lingua principale
- C++
- Stelle
- 127k
- Fork
- 25.5k
- Merge medio
- 3g 17h
- PR unite (30g)
- 302
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di react/react-native
-
Needs: Triage :mag: Platform: Android
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
react/react-native#60177 ·
I maintainer di solito rispondono entro 2 giorni
-
Android: with view recycling on, a recycled View keeps its nextFocusLeftForse già presa @lazerg l’ha presa oggi. ApertaNeeds: Triage :mag: Platform: Android
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
react/react-native#60167 ·
I maintainer di solito rispondono entro 2 giorni
-
Needs: Author Feedback Needs: Repro
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
react/react-native#60091 · 1 commento ·
I maintainer di solito rispondono entro 2 giorni
-
Needs: Triage :mag:
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
react/react-native#60000 ·
I maintainer di solito rispondono entro 2 giorni
-
`yarn test-ios` exits before building RNTester: `objc-test.sh` launches the WebSocket server script #59433 deletedForse già presa @lazerg l’ha presa 8 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
react/react-native#59939 ·
I maintainer di solito rispondono entro 2 giorni
Tutte le issue di react/react-native
Issue simili
-
[UBSan] spawn_simulator passes null child_options.args to uv_spawn (execvp nonnull violation)Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 79/100
tenstorrent/tt-umd#4017 ·
I maintainer di solito rispondono entro 3 giorni
-
difficulty:easy func:gui prio:low type:bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
NatronGitHub/Natron#1538 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
hyprwm/hyprsunset#103 · 1 commento ·
-
Feature request
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
qbittorrent/qBittorrent#25338 ·
I maintainer di solito rispondono entro 2 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 77/100
I maintainer di solito rispondono entro 1 giorno