C++ API snapshots: `ReactCommon` and `ReactAndroid` read the tvOS view headers, as `scripts/cxx-api/config.yml` does not exclude `*/platform/tvos/*`

Abierto Apto para principiantes
#60,180 3 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
72/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
bash, cpp, yaml

Línea de trabajo

Empieza leyendo los exclude_patterns de ReactCommon, ReactAndroid y ReactApple en scripts/cxx-api/config.yml y compáralos después con las rutas de plataforma descritas en el issue. El reproductor comprueba las exclusiones y las instantáneas de API confirmadas en el repositorio; ejecuta bash repro.sh en un checkout para confirmar el resultado actual. El objetivo se alcanza cuando ReactCommon y ReactAndroid excluyen los encabezados de tvOS y las instantáneas afectadas dejan de incluir la clase de tvOS, mientras que las exclusiones de las demás plataformas permanecen intactas.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Needs: Attention Needs: Version Info Platform: Android Platform: tvOS
Description

scripts/cxx-api/config.yml leaves each view platform folder out of the snapshots that are not for it: ReactCommon excludes */platform/cxx/*, windows, macos, ios and android (L27-L33), and ReactAndroid excludes cxx, windows, macos and ios (L58-L65). Neither names */platform/tvos/*, so both read ReactCommon/react/renderer/components/view/platform/tvos/:

  • all four ReactCommon*Cxx.api list class facebook::react::HostPlatformViewProps with public bool focusable;, which only the tvOS header declares (L28);
  • each ReactAndroid*Cxx.api merges the tvOS HostPlatformViewProps into Android's. On main both declare bool focusable{false};, so it does not show; https://github.com/react/react-native/pull/59048 makes Android's std::optional<bool> focusable{}, and its regenerated ReactAndroidDebugCxx.api lists both public bool focusable; and public std::optional<bool> focusable; in the one class.

ReactApple does not exclude */platform/tvos/* either, and it does exclude */platform/cxx/*, the folder React-Fabric.podspec compiles for iOS (L168), so ReactAppleDebugCxx.api lists the tvOS class where iOS has using HostPlatformViewProps = BaseViewProps;.

Steps to reproduce
  1. Run bash repro.sh from the reproducer below. It sparse-clones main, matches each view platform's HostPlatformViewProps.h against each snapshot's exclude_patterns in scripts/cxx-api/config.yml (with the template's */tests/* and */samples/*), and prints the HostPlatformViewProps class of the committed ReactCommon*Cxx.api and ReactAndroidDebugCxx.api. bash repro.sh <path to a react-native checkout> reads a checkout instead.

Expected: ReactCommon and ReactAndroid read nothing under platform/tvos, so no ReactCommon*Cxx.api lists a HostPlatformViewProps class and the ReactAndroid*Cxx.api class holds Android's members only; their other platform exclusions stay as they are.
Actual: both read platform/tvos/.../HostPlatformViewProps.h, and all four ReactCommon*Cxx.api list the tvOS class with public bool focusable; (log below).

React Native Version

main at bbfd391496 (nightly)

Affected Platforms

Other (please specify): the C++ API snapshots in scripts/cxx-api

Output of npx @react-native-community/cli info
Not applicable: this is the configuration of React Native's own C++ API snapshots. The reproducer's run:
react-native bbfd391 (2026-11-19), MINGW64_NT-10.0-26300 3.6.10-5a1665c8.x86_64, bash 5.3.15(2)-release
Stacktrace or Logs
react-native bbfd391 (2026-11-19), MINGW64_NT-10.0-26300 3.6.10-5a1665c8.x86_64, bash 5.3.15(2)-release
platform/android/.../HostPlatformViewProps.h:44:  bool focusable{false};
platform/cxx/.../HostPlatformViewProps.h:15:using HostPlatformViewProps = BaseViewProps;
platform/tvos/.../HostPlatformViewProps.h:28:  bool focusable{false};
config.yml ReactCommon exclude_patterns naming a platform folder: */platform/cxx/* */platform/windows/* */platform/macos/* */platform/ios/* */platform/android/*
  ReactCommon reads HostPlatformViewProps.h from: platform/tvos
config.yml ReactAndroid exclude_patterns naming a platform folder: */platform/cxx/* */platform/windows/* */platform/macos/* */platform/ios/*
  ReactAndroid reads HostPlatformViewProps.h from: platform/android platform/tvos
config.yml ReactApple exclude_patterns naming a platform folder: */platform/cxx/* */platform/windows/* */platform/macos/* */platform/android/*
  ReactApple reads HostPlatformViewProps.h from: platform/tvos
ReactCommonDebugCxx.api:
  676: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
  679:   public bool focusable;
ReactCommonFrameworksCxx.api:
  1238: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
  1241:   public bool focusable;
ReactCommonNewarchCxx.api:
  675: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
  678:   public bool focusable;
ReactCommonReleaseCxx.api:
  675: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
  678:   public bool focusable;
ReactAndroidDebugCxx.api:
  1329: class facebook::react::HostPlatformViewProps : public facebook::react::BaseViewProps {
  1333:   public bool focusable;
SUMMARY: snapshots whose exclude_patterns let them read platform/tvos/.../HostPlatformViewProps.h: ReactCommon ReactAndroid; committed ReactCommon snapshots with class facebook::react::HostPlatformViewProps: ReactCommonDebug ReactCommonFrameworks ReactCommonNewarch ReactCommonRelease
MANDATORY Reproducer

https://gist.github.com/YevheniiKotyrlo/d19e454d6ff5635c01ac24ce902e513e — bash repro.sh exits 1 while ReactCommon or ReactAndroid reads platform/tvos or a committed ReactCommon*Cxx.api lists class facebook::react::HostPlatformViewProps, and 0 once neither holds.

Screenshots and Videos

No response

Lenguaje dominante
C++
Estrellas
127k
Forks
25.5k
Merge medio
3 d 17 h
PR fusionados (30 d)
302

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de react/react-native

Todos los issues de react/react-native

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.